Skip to content

fix: repair committed type errors and restore create-wizard components (#1824) #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Akeem0604 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: repair committed type errors and restore create-wizard components (#1824) #1869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions src/app/api/commitments/[id]/early-exit/route.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
import { NextRequest } from 'next/server';
import { POST } from './route';
import { diagnosticsService } from '@/lib/backend/diagnostics';
import { CsrfValidationError } from '@/lib/backend/errors';
import { randomUUID } from 'crypto';

// ── Mocks ─────────────────────────────────────────────────────────────────────
Expand Down Expand Up @@ -35,12 +36,18 @@ vi.mock('@/lib/backend/idempotency', () => ({

vi.mock('@/lib/backend/logger', () => ({
logEarlyExit: vi.fn(),
logInfo: vi.fn(),
logWarn: vi.fn(),
logError: vi.fn(),
}));

import { checkRateLimit } from '@/lib/backend/rateLimit';
import { assertMutationCsrf } from '@/lib/backend/csrf';
import { requireAuth } from '@/lib/backend/requireAuth';
import { earlyExitCommitmentOnChain, getCommitmentFromChain } from '@/lib/backend/services/contracts';
import {
earlyExitCommitmentOnChain,
getCommitmentFromChain,
} from '@/lib/backend/services/contracts';
import { idempotencyService } from '@/lib/backend/idempotency';
import { logEarlyExit } from '@/lib/backend/logger';

Expand All @@ -64,15 +71,15 @@ function createMockRequest(
): NextRequest {
const req = new NextRequest(url, {
method: options.method || 'POST',
body: options.body ? JSON.stringify(options.body) : undefined,
...(options.body ? { body: JSON.stringify(options.body) } : {}),
});

if (options.idempotencyKey) {
const headers = new Headers(req.headers);
headers.set('idempotency-key', options.idempotencyKey);
return new NextRequest(url, {
method: options.method || 'POST',
body: options.body ? JSON.stringify(options.body) : undefined,
...(options.body ? { body: JSON.stringify(options.body) } : {}),
headers,
});
}
Expand All @@ -94,8 +101,8 @@ async function parseResponse(response: Response): Promise<ParsedResponse> {

// ── Test Data ─────────────────────────────────────────────────────────────────

const VALID_ADDRESS = `GBAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA`;
const DIFFERENT_ADDRESS = `GBAAAAABBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB`;
const VALID_ADDRESS = `G`.padEnd(56, 'A');
const DIFFERENT_ADDRESS = `H`.padEnd(56, 'B');
const COMMITMENT_ID = 'commitment-exit-test-123';

const MOCK_COMMITMENT_ACTIVE = {
Expand All @@ -118,6 +125,7 @@ describe('POST /api/commitments/[id]/early-exit - Authorization & Boundary Valid
beforeEach(() => {
vi.clearAllMocks();
diagnosticsService.clear();
mockAssertCsrf.mockImplementation(() => undefined);
mockCheckRateLimit.mockResolvedValue(true);
mockRequireAuth.mockReturnValue({
user: { address: VALID_ADDRESS, csrfToken: 'token' },
Expand All @@ -131,7 +139,7 @@ describe('POST /api/commitments/[id]/early-exit - Authorization & Boundary Valid
reference: 'exit-ref-123',
});
mockIdempotency.getRecord.mockResolvedValue(null);
mockIdempotency.start.mockResolvedValue(undefined);
mockIdempotency.start.mockResolvedValue(true);
mockIdempotency.complete.mockResolvedValue(undefined);
mockIdempotency.fail.mockResolvedValue(undefined);
});
Expand Down Expand Up @@ -176,7 +184,7 @@ describe('POST /api/commitments/[id]/early-exit - Authorization & Boundary Valid

const result = await parseResponse(response);
expect(result.status).toBe(403);
expect(result.data.error.code).toBe('FORBIDDEN_ERROR');
expect(result.data.error.code).toBe('FORBIDDEN');
expect(result.data.error.message).toContain('Session authentication failed');
});

Expand Down Expand Up @@ -239,7 +247,7 @@ describe('POST /api/commitments/[id]/early-exit - Authorization & Boundary Valid
// ── State Precondition Tests ───────────────────────────────────────────────

it('rejects early-exit of non-existent commitment', async () => {
mockGetCommitment.mockResolvedValue(null);
mockGetCommitment.mockResolvedValue(null as never);

const req = createMockRequest(`http://localhost/api/commitments/${COMMITMENT_ID}/early-exit`, {
body: {
Expand Down Expand Up @@ -495,7 +503,7 @@ describe('POST /api/commitments/[id]/early-exit - Authorization & Boundary Valid

it('fails on CSRF validation failure', async () => {
mockAssertCsrf.mockImplementation(() => {
throw new Error('CSRF token invalid');
throw new CsrfValidationError('CSRF token invalid');
});

const req = createMockRequest(`http://localhost/api/commitments/${COMMITMENT_ID}/early-exit`, {
Expand All @@ -509,7 +517,8 @@ describe('POST /api/commitments/[id]/early-exit - Authorization & Boundary Valid
const response = await POST(req, context, 'correlation-123');

const result = await parseResponse(response);
expect(result.status).toBe(400);
expect(result.status).toBe(403);
expect(result.data.error.code).toBe('CSRF_INVALID');
});

// ── Rate Limit Tests ───────────────────────────────────────────────────────
Expand All @@ -529,7 +538,7 @@ describe('POST /api/commitments/[id]/early-exit - Authorization & Boundary Valid

const result = await parseResponse(response);
expect(result.status).toBe(429);
expect(result.data.error.code).toBe('TOO_MANY_REQUESTS_ERROR');
expect(result.data.error.code).toBe('TOO_MANY_REQUESTS');
});

// ── Transaction Response Validation ────────────────────────────────────────
Expand Down
Loading