Skip to content

Created System Monitor pages#23

Merged
DanielHerr merged 1 commit into
masterfrom
dev
May 8, 2026
Merged

Created System Monitor pages#23
DanielHerr merged 1 commit into
masterfrom
dev

Conversation

@DanielHerr
Copy link
Copy Markdown
Owner

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 8, 2026

Deploy Preview for daniel-herr-software ready!

Name Link
🔨 Latest commit 8e0a477
🔍 Latest deploy log https://app.netlify.com/projects/daniel-herr-software/deploys/69fe64a967b3f900090d2e7d
😎 Deploy Preview https://deploy-preview-23--daniel-herr-software.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100
Accessibility: 100
Best Practices: 75
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@DanielHerr DanielHerr merged commit 70e03a6 into master May 8, 2026
6 of 7 checks passed
@netlify
Copy link
Copy Markdown

netlify Bot commented May 8, 2026

Deploy Preview for daniel-herr-software-forms ready!

Name Link
🔨 Latest commit 8e0a477
🔍 Latest deploy log https://app.netlify.com/projects/daniel-herr-software-forms/deploys/69fe64a9dcdfa000088f03ac
😎 Deploy Preview https://deploy-preview-23--daniel-herr-software-forms.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Visit the preview URL for this PR (updated for commit 8e0a477):

https://daniel-herr-software--pr23-dev-jyii4z7n.web.app

(expires Fri, 15 May 2026 22:33:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8c152685cc1a60c2381e223a321e638cf5e1d307

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the "System Monitor" Chrome App by adding a product page, an uninstallation feedback form, and updating the main index. Review feedback identifies a redundant closing tag in the feedback form and recommends correcting the heading hierarchy and indentation in the changelog to improve accessibility and maintain code consistency.

Comment on lines +52 to +53
</label><br>
</label>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a redundant closing </label> tag on line 53. Removing it ensures the HTML is well-formed and prevents potential rendering issues.

			</label><br>

Comment thread main/System_Monitor.html
Comment on lines +43 to +54
<ol reversed>
<li>
<h2>4.0 - May 8, 2026</h2>
<ul>
<li>Rename from Monitor Panel</li>
<li>Added full view UI surface with detailed CPU, RAM, battery, display, and network information</li>
<li>Moved settings directly into app instead of relying on Memory/Processor Monitor extensions settings</li>
<li>Combined CPU and RAM floating panels and added battery</li>
<li>Licensed app as GPLv3</li>
</ul>
</li>
</ol>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation of the changelog section is inconsistent with the rest of the file. Additionally, the version header should be changed from <h2> to <h4> to maintain a correct heading hierarchy under the <h3>Changelog</h3> section, which improves accessibility and SEO.

Suggested change
<ol reversed>
<li>
<h2>4.0 - May 8, 2026</h2>
<ul>
<li>Rename from Monitor Panel</li>
<li>Added full view UI surface with detailed CPU, RAM, battery, display, and network information</li>
<li>Moved settings directly into app instead of relying on Memory/Processor Monitor extensions settings</li>
<li>Combined CPU and RAM floating panels and added battery</li>
<li>Licensed app as GPLv3</li>
</ul>
</li>
</ol>
<ol reversed>
<li>
<h4>4.0 - May 8, 2026</h4>
<ul>
<li>Rename from Monitor Panel</li>
<li>Added full view UI surface with detailed CPU, RAM, battery, display, and network information</li>
<li>Moved settings directly into app instead of relying on Memory/Processor Monitor extensions settings</li>
<li>Combined CPU and RAM floating panels and added battery</li>
<li>Licensed app as GPLv3</li>
</ul>
</li>
</ol>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant