Task/wp 1196 update django for ds#1716
Open
van-go wants to merge 23 commits into
Open
Conversation
…unnecessary entries
rstijerina
reviewed
Jul 15, 2026
Comment on lines
+296
to
+299
| # djangocms-forms-maintained still uses the pre-Django 5 storage API. Keep its | ||
| # configuration sourced from STORAGES until the archived plugin is replaced. | ||
| DEFAULT_FILE_STORAGE = STORAGES["default"]["BACKEND"] | ||
| apply_storage_compatibility() |
Member
There was a problem hiding this comment.
Can we update django-cms as well to not need this compatibility function?
Collaborator
There was a problem hiding this comment.
I hope so! Please tell me how this goes! I have long been worried about the form plugin, but 'django-cms>=3.0' suggests forms could still work.
Why Now Is the Right Time to Migrate from django CMS 3.11
— Django CMS Blog | Jan. 10, 2026
wesleyboar
reviewed
Jul 21, 2026
| attrdict = { git = "https://github.com/DesignSafe-CI/AttrDict", rev = "83b779ee82d5b0e33be695d398162b8f2430ff33" } | ||
| django-recaptcha2 = { git = "https://github.com/DesignSafe-CI/django-recaptcha2", tag = "v1.4.1--compat-django4" } | ||
| djangocms-cascade = { git = "https://github.com/DesignSafe-CI/djangocms-cascade", rev = "9e9f9e3088a0fcfdc1b27ad7e08b68390aa6a570" } | ||
| djangocms-cascade = { git = "https://github.com/van-go/djangocms-cascade.git", rev = "009a7d8ccc5e8b1ff645091fe6780af71a798b31" } |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
Update Django Version
The version being used by the lockfile is Django 4.2.27.
Django 4.2.x remains supported until April 2026.
Recommended target: Django 5.2.12 (latest 5.2 LTS patch).
PR Status
Related Links
Summary of Changes
pyproject.toml
Three dependency constraints changed:
poetry.lock
The lockfile was regenerated with Poetry 2.1.3. Principal resolved changes:
common_settings.py
Added the compatibility helper import:
from designsafe.settings.djangocms_forms_compat import apply_storage_compatibilityThen, after the Django 5 STORAGES configuration:
This lets the archived forms plugin obtain its legacy setting from the authoritative Django 5 storage configuration. It does not introduce a separate storage configuration.
djangocms_forms_compat.py
This is a new compatibility adapter for
djangocms-forms-maintained:It conditionally restores the removed
get_storage_classfunction:The conditional makes it safe if the code is ever run with an older Django version where
get_storage_classstill exists.This adapter is necessary because
djangocms-forms-maintainedstill:DEFAULT_FILE_STORAGEsettingdjango.core.files.storage.get_storage_classIt should be removed once that archived plugin is replaced with a Django 5-native forms package.
Testing Steps
UI
Notes