-
Notifications
You must be signed in to change notification settings - Fork 16
Task/wp 1196 update django for ds #1716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
van-go
wants to merge
23
commits into
main
Choose a base branch
from
task/WP-1196-Update-Django-for-DS
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
e9296a1
add back NH Type, Year Pub, and Clear filters
van-go 795c38f
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go 67a0e65
cert-updates
van-go 52d892c
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go e5c271c
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go e7b055b
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go ece6e39
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go 40e39f8
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go 25aa2f0
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go cb3ddc6
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go f1eb0f7
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go 674e4b3
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go ae4f839
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go 0da44cd
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go 0632d99
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go 0e144dc
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go 88a519b
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go ed01b72
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go a7d292d
Merge branch 'main' of https://github.com/DesignSafe-CI/portal
van-go d793e09
Update Django to 5.2.12 and add compatibility for djangocms-forms
van-go edac23f
Update SSL certificate configuration to enhance key usage and remove …
van-go d654094
Upgrade django CMS to 4.1
van-go 733d001
Upgrade django CMS to 5.0
van-go File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| """Compatibility helpers for the unmaintained djangocms-forms package.""" | ||
|
|
||
| from django.core.files import storage | ||
| from django.utils.module_loading import import_string | ||
|
|
||
|
|
||
| def apply_storage_compatibility(): | ||
| """Restore the storage loader removed in Django 5 for djangocms-forms.""" | ||
| if not hasattr(storage, "get_storage_class"): | ||
| storage.get_storage_class = import_string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update django-cms as well to not need this compatibility function?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope so! Please tell me how this goes! I have long been worried about the form plugin, but
'django-cms>=3.0'suggests forms could still work.