GoPiGo3 C++ API Fixes for https://github.com/DexterInd/GoPiGo3/issues/369, plus README and clean utility#371
Open
slowrunner wants to merge 4 commits into
Open
GoPiGo3 C++ API Fixes for https://github.com/DexterInd/GoPiGo3/issues/369, plus README and clean utility#371slowrunner wants to merge 4 commits into
slowrunner wants to merge 4 commits into
Conversation
… int as signed int variable (Causes encoder crossing 0 backward to become 8xxxxxxxxxxx instead of -1)
…ared as integer - needs to be float for 16 tick motors (5.3333 ticks per degree)
…s duplicates when user follows the compile instructions for an Example program or a new program of the user's creation: (All should be "static")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed C++ GoPiGo3 API GoPiGo3.get_motor_encoder() division to properly return signed int32.
Changed C++ GoPiGo3 class variable GoPiGo3.MOTOR_TICKS_PER_DEGREE from int to float
(for 16 tick motors value is 5.3333 ticks per degree not integer 5)
Changed in header file definitions to static to prevent duplication when building per documentation in the Examples:
Added clean.sh utility to remove cmake and make products