Skip to content

test(combobox): migrate filtering tests to browser mode#14060

Open
jcfranco wants to merge 6 commits intodevfrom
jcfranco/14012-port-combobox-filtering-tests-to-browser-mode
Open

test(combobox): migrate filtering tests to browser mode#14060
jcfranco wants to merge 6 commits intodevfrom
jcfranco/14012-port-combobox-filtering-tests-to-browser-mode

Conversation

@jcfranco
Copy link
Copy Markdown
Member

@jcfranco jcfranco commented Mar 11, 2026

Related Issue: #14012

Summary

✨🧪✨

@jcfranco jcfranco requested a review from Copilot March 11, 2026 04:07
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Mar 11, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ports combobox filtering-related E2E coverage from Stencil’s newE2EPage runner to the Vitest browser-mode runner to address an unstable filtering/toggling test (Issue #14012).

Changes:

  • Removed the filtering test suite from combobox.e2e.ts (Stencil E2E).
  • Added a new describe("filtering") suite to combobox.browser.e2e.tsx using mount, userEvent, and browser-mode locators/commands.
  • Introduced browser-mode debounce handling via DEBOUNCE.filter and mouse commands utilities.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
packages/components/src/components/combobox/combobox.e2e.ts Removes the Stencil E2E filtering test suite being migrated.
packages/components/src/components/combobox/combobox.browser.e2e.tsx Adds browser-mode implementations of the combobox filtering tests and related utilities/imports.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Mar 19, 2026
@jcfranco jcfranco changed the title test(combobox): port filtering tests to browser mode test(combobox): migrate filtering tests to browser mode Mar 23, 2026
@jcfranco jcfranco marked this pull request as ready for review March 23, 2026 20:41
Copy link
Copy Markdown
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jcfranco
Copy link
Copy Markdown
Member Author

Spotted an unexpected error in the migrated test. 🫠 I'll take a look and will merge after resolving.

@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Mar 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip visual snapshots Pull requests that do not need visual regression testing. Stale Issues or pull requests that have not had recent activity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants