test(combobox): migrate filtering tests to browser mode#14060
test(combobox): migrate filtering tests to browser mode#14060
Conversation
There was a problem hiding this comment.
Pull request overview
Ports combobox filtering-related E2E coverage from Stencil’s newE2EPage runner to the Vitest browser-mode runner to address an unstable filtering/toggling test (Issue #14012).
Changes:
- Removed the
filteringtest suite fromcombobox.e2e.ts(Stencil E2E). - Added a new
describe("filtering")suite tocombobox.browser.e2e.tsxusingmount,userEvent, and browser-mode locators/commands. - Introduced browser-mode debounce handling via
DEBOUNCE.filterand mousecommandsutilities.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/components/src/components/combobox/combobox.e2e.ts | Removes the Stencil E2E filtering test suite being migrated. |
| packages/components/src/components/combobox/combobox.browser.e2e.tsx | Adds browser-mode implementations of the combobox filtering tests and related utilities/imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/components/src/components/combobox/combobox.browser.e2e.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/combobox/combobox.browser.e2e.tsx
Outdated
Show resolved
Hide resolved
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
|
Spotted an unexpected error in the migrated test. 🫠 I'll take a look and will merge after resolving. |
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
Related Issue: #14012
Summary
✨🧪✨