BF: Stabilize 3D camera framing across loads and resizes. - #90
Open
marcotag93 wants to merge 1 commit into
Open
Conversation
marcotag93
commented
Jun 8, 2026
marcotag93
commented
- Frame the 3D camera once on first content, guarded by _camera_framed, so the TrackballController pivot is set from the scene bounding sphere instead of the PerspectiveCamera defaults.
- Reframe when a T1 is loaded so the rotation pivot is the anatomical volume centre regardless of tractogram/T1 load order.
- Wrap ShowManager._resize to snapshot and restore the 3D camera around FURY's update_viewports reframe, so a window resize keeps the 3D view fixed in place.
- Frame the 3D camera once on first content, guarded by _camera_framed, so the TrackballController pivot is set from the scene bounding sphere instead of the PerspectiveCamera defaults. - Reframe when a T1 is loaded so the rotation pivot is the anatomical volume centre regardless of tractogram/T1 load order. - Wrap ShowManager._resize to snapshot and restore the 3D camera around FURY's update_viewports reframe, so a window resize keeps the 3D view fixed in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.