Skip to content

BF: Stabilize 3D camera framing across loads and resizes. #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcotag93 wants to merge 1 commit into
base: ui-revamp
Choose a base branch
from
Open

BF: Stabilize 3D camera framing across loads and resizes. #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions tractome/ui/_visualization_section.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ def __init__(self):
self._3D_camera.add(DirectionalLight())
self._3D_scene.add(self._3D_camera)
self._3D_controller = TrackballController(self._3D_camera)
self._camera_framed = False

self._2D_scene = window.Scene(background=(0.2, 0.2, 0.2))
self._2D_scene.add(DirectionalLight())
Expand Down Expand Up @@ -120,6 +121,7 @@ def _register_clicks(event):
# The wgpu canvas reports its own resize before Qt's
# CenterSectionWidget.resizeEvent fires, so listen on both.
self.show_manager.resize_callback(self._on_canvas_resize)
self._install_3d_view_preserving_resize()
QTimer.singleShot(0, self._reposition_axes_gizmo)

def _build_display_info_overlay(self, parent_layout):
Expand Down Expand Up @@ -205,6 +207,10 @@ def add_visualization(self, visualizations, visualization_type="unknown"):
Type/category of the visualization payload.
"""
self._3D_scene.add(*visualizations)
# Frame once on first content; reframe on T1 so the pivot is the volume centre.
if not self._camera_framed or visualization_type == "t1":
window.update_camera(self._3D_camera, None, self._3D_scene)
self._camera_framed = True
if visualization_type == "tractogram":
self._update_display_info()
self._keystroke_card.setVisible(True)
Expand Down Expand Up @@ -245,6 +251,18 @@ def _on_canvas_resize(self, size):
anchor.local.position = [max(int(width) - margin, margin), margin, 0.5]
self.show_manager.render()

def _install_3d_view_preserving_resize(self):
"""Snapshot/restore the 3D camera around FURY's reframing ``_resize``."""
original_resize = self.show_manager._resize

def resize(size):
state = self._3D_camera.get_state() if self._camera_framed else None
original_resize(size)
if state is not None:
self._3D_camera.set_state(state)

self.show_manager._resize = resize

def _reposition_axes_gizmo(self):
"""Move the axes-gizmo anchor to the bottom-right of the viewport.

Expand Down