Redesign Comprehensive Exam and Open Seminar: RPC/DPGC/PGCS/Dean flow#1936
Merged
Conversation
Replace the Convener placeholder role with the student's live RPC committee (per-member consent + comments), HOD-DPGC and HOD-PGCS review stages (both standing in for the real designations, mapped to the student's HOD), and a real Dean Academic final sign-off. Also includes a security/correctness pass on the new endpoints: - Fix IDOR: supervisor_comprehensive_exam_detail and supervisor_open_seminar_detail had no ownership check - Clear stale PGCS/HOD reviewer fields on RPC re-finalize so a resubmitted item stops showing as already-decided history - Validate RPC result values against RESULT_CHOICES before saving - Freeze RPC committee membership while an attempt is rpc_pending, to close a consent-bypass/stale-consent gap - Remove leftover debug print statements
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resultvalues on RPC consent endpointsprint()statementsTest plan
python manage.py migrateandpython manage.py check