review: test: add regression test for toString() with complex comments

[MartinWitt]

Cleanup and package move

[MartinWitt]

Had some claude tokens left and the test package seems really off before

[Copilot]

Pull request overview

Adds/relocates a regression test intended to ensure CtType#toString() does not crash when pretty-printing sources containing complex comment patterns.

Changes:

• Added a new JUnit/@ModelTest-based regression test ToStringCommentTest that loads two Java fixtures and calls toString() on all parsed types.
• Added two new Java fixture sources under src/test/resources/spoon/test/prettyprinter/toStringCommentTest.
• Removed the previous spoon.toStringBugTest.ToStringBugTest regression test.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/test/resources/spoon/test/prettyprinter/toStringCommentTest/TestClass2.java	Adds a large Java fixture intended to reproduce complex comment handling during toString() pretty-printing.
src/test/resources/spoon/test/prettyprinter/toStringCommentTest/TestClass.java	Adds a second Java fixture used by the regression test.
src/test/java/spoon/toStringBugTest/ToStringBugTest.java	Removes the previous regression test for issue #3382.
src/test/java/spoon/test/prettyprinter/ToStringCommentTest.java	Introduces the new regression test using @ModelTest to build a model from the fixtures and invoke toString().

Comments suppressed due to low confidence (1)

src/test/java/spoon/test/prettyprinter/ToStringCommentTest.java:38

• The current assertion only checks that type.toString() is non-null (which is unlikely to add value) and the custom fail message won’t be used if toString() throws. Prefer an assertion that explicitly verifies toString() does not throw (and optionally that the result is non-empty) so the regression intent is enforced and failures identify the offending type.

		var types = launcher.getFactory().Class().getAll();
		assertThat(types).withFailMessage("Should load test resources").isNotEmpty();

		for (CtType<?> type : types) {
			assertThat(type.toString()).withFailMessage("toString() should not return null for type: " + type.getQualifiedName()).isNotNull();
		}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.