Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Following up on @pdurbin's work in #845, this PR updates how users select the dataset type in the dataset creation flow.
For now, we’ve hardcoded the dataset type descriptions (“dataset” and “review”) as a temporary solution until the new field is added.Update: this was fixed in 7c355f4.This is the first step toward supporting dataset types in the SPA, more enhancements coming soon.
Storybook links:
Which issue(s) this PR closes:
Depends on
This PR depends on the following backend PR:
Special notes for your reviewer:
Suggestions on how to test this:
You can follow the instructions provided at the end of this script or use this script provided to configure review types in root:
Pre-requisites for testing this.
As mentioned in IQSS/dataverse#11753:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.
The "Create Dataset" page now has a Dataset Type dropdown. See the latest screenshots here: #876 (comment)
Is there a release notes or changelog update needed for this change?:
Not for now, might be good to add it after work related to dataset types is done.
Additional documentation: