feat(pam): add NTLM auth support for MSSQL #6544
Closed
Claude / Claude Code Review
completed
May 20, 2026 in 17m 19s
Code review found 1 important issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | backend/src/ee/services/pam-resource/mssql/mssql-resource-schemas.ts:25-29 |
Existing MSSQL accounts break after upgrade — no authMethod backfill |
Annotations
Check failure on line 29 in backend/src/ee/services/pam-resource/mssql/mssql-resource-schemas.ts
claude / Claude Code Review
Existing MSSQL accounts break after upgrade — no authMethod backfill
Pre-existing MSSQL PAM accounts will break after this PR ships: their stored credentials are `{username, password}` with no `authMethod` field, but every endpoint now serializes through a `z.discriminatedUnion("authMethod", ...)` (`SanitizedMsSQLCredentialsSchema`, `MsSQLAccountCredentialsSchema`, `MsSQLSessionCredentialsSchema`). Fastify-zod's serializerCompiler throws `ResponseValidationError`, so account list/get, GET /credentials, and the gateway session-credentials endpoint will all return
Loading