feat(pam): add NTLM auth support for MSSQL #6544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

saifsmailbox98 wants to merge 6 commits into main from saif/pam-226-add-ntlm-auth-support-for-mssql-in-pam

Closed

feat(pam): add NTLM auth support for MSSQL #6544

chore: shorten schema comments

Claude / Claude Code Review completed May 20, 2026 in 18m 13s

Code review found 1 potential issue

Found 5 candidates, confirmed 1. See review comments for details.

Details

Severity	Count
🔴 Important	0
🟡 Nit	1
🟣 Pre-existing	0

Severity	File:Line	Issue
🟡 Nit	`backend/src/ee/services/pam-resource/shared/sql/sql-resource-factory.ts:350-358`	Rotation flow drops authMethod/domain

Annotations

Check warning on line 358 in backend/src/ee/services/pam-resource/shared/sql/sql-resource-factory.ts

claude / Claude Code Review

Rotation flow drops authMethod/domain

Asymmetric update: `validateAccountCredentials` was updated to forward `authMethod`/`domain` to `executeWithGateway` (lines 350-358), but the parallel `rotateAccountCredentials` call (lines 397-408) was not — it still passes only `username`/`password` from `rotationAccountCredentials`. Since `MsSQLAccountCredentialsSchema` (a union of NTLM + SqlLogin) is accepted for `MsSQLResourceSchema.rotationAccountCredentials`, an admin can configure NTLM rotation creds. The bug is latent today because MSSQ

View more details on Claude