Skip to content

Implement s3 profile modal (WIP) #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garronej wants to merge 14 commits into
base: explorer_deep_rework
Choose a base branch
from

Add an overlay icon to show which object and prefixes are public.

683c957
Select commit
Loading
Failed to load commit list.
Open

Implement s3 profile modal (WIP) #1070

Add an overlay icon to show which object and prefixes are public.
683c957
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 1, 2026 in 48s

Quality Gate failed

Failed conditions
1 Security Hotspot
C Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 309 in web/src/ui/pages/s3Explorer/dialogs/S3ProfileDialog.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Imported JSX component S3ProfileForm_headless must be in PascalCase 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ19CBhCt-zbsGOG2a0r&open=AZ19CBhCt-zbsGOG2a0r&pullRequest=1070

Check warning on line 298 in web/src/ui/shared/codex/s3ProfileDialog/S3ProfileDetails/S3ProfileDetails.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ3ZQ6VmSVepKWF9xVnd&open=AZ3ZQ6VmSVepKWF9xVnd&pullRequest=1070

Check warning on line 16 in web/src/core/usecases/s3ProfilesCreationUiController/thunks.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code to remove this label and the need for it. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ19CBoft-zbsGOG2a1P&open=AZ19CBoft-zbsGOG2a1P&pullRequest=1070

Check failure on line 780 in web/src/ui/shared/codex/S3ExplorerMainView/S3ExplorerMainView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ3j-QCVG5IjBZINUj5k&open=AZ3j-QCVG5IjBZINUj5k&pullRequest=1070

Check failure on line 29 in web/src/ui/shared/codex/s3ProfileDialog/S3ProfileDetails/S3ProfileDetails.stories.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure this AWS Session token gets revoked, changed, and removed from the code. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ3ZQ6VaSVepKWF9xVnb&open=AZ3ZQ6VaSVepKWF9xVnb&pullRequest=1070

Check warning on line 28 in web/src/ui/shared/textEditor/CodeTextEditor/LegacyModeCodeTextEditor.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected an assignment or function call and instead saw an expression. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ3ZQ6VySVepKWF9xVng&open=AZ3ZQ6VySVepKWF9xVng&pullRequest=1070

Check warning on line 3 in web/src/core/usecases/s3ProfilesCreationUiController/state.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'clean-architecture' imported multiple times. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ19CBovt-zbsGOG2a1Q&open=AZ19CBovt-zbsGOG2a1Q&pullRequest=1070

Check warning on line 58 in web/src/ui/shared/codex/s3ProfileDialog/S3ProfileDetails/S3ProfileDetails.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ3ZQ6VmSVepKWF9xVnc&open=AZ3ZQ6VmSVepKWF9xVnc&pullRequest=1070

Check warning on line 478 in web/src/core/usecases/s3ProfilesDetailsUiController/decoupledLogic/codeSnippets.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ19CBoXt-zbsGOG2a1G&open=AZ19CBoXt-zbsGOG2a1G&pullRequest=1070

Check warning on line 486 in web/src/core/usecases/s3ProfilesDetailsUiController/decoupledLogic/codeSnippets.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ19CBoXt-zbsGOG2a1J&open=AZ19CBoXt-zbsGOG2a1J&pullRequest=1070

Check warning on line 329 in web/src/core/usecases/s3ExplorerUiController/decoupledLogic/bucketPolicy.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`String.raw` should be used to avoid escaping `\`. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ3fqqyUp8mAFfkQEm1O&open=AZ3fqqyUp8mAFfkQEm1O&pullRequest=1070

Check warning on line 203 in web/src/ui/pages/s3Explorer/dialogs/S3ProfileDialog.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Imported JSX component S3ProfileDetails_headless must be in PascalCase 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ19CBhCt-zbsGOG2a0q&open=AZ19CBhCt-zbsGOG2a0q&pullRequest=1070

Check warning on line 77 in web/src/ui/pages/s3Explorer/dialogs/S3ProfileDialog.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ3YfPPBqgvhdYcr_ypI&open=AZ3YfPPBqgvhdYcr_ypI&pullRequest=1070

Check warning on line 329 in web/src/core/usecases/s3ExplorerUiController/decoupledLogic/bucketPolicy.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ3fqqyUp8mAFfkQEm1N&open=AZ3fqqyUp8mAFfkQEm1N&pullRequest=1070

Check warning on line 29 in web/src/ui/shared/textEditor/CodeTextEditor/LegacyModeCodeTextEditor.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Block is redundant. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ3ZQ6VySVepKWF9xVnf&open=AZ3ZQ6VySVepKWF9xVnf&pullRequest=1070

Check warning on line 496 in web/src/core/usecases/s3ProfilesDetailsUiController/decoupledLogic/codeSnippets.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ19CBoXt-zbsGOG2a1L&open=AZ19CBoXt-zbsGOG2a1L&pullRequest=1070

Check warning on line 40 in web/src/ui/shared/textEditor/CodeTextEditor/LegacyModeCodeTextEditor.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ3ZQ6VySVepKWF9xVnh&open=AZ3ZQ6VySVepKWF9xVnh&pullRequest=1070

Check warning on line 56 in web/src/core/usecases/s3ProfilesDetailsUiController/selectors.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not use nested template literals. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ19CBoNt-zbsGOG2a1E&open=AZ19CBoNt-zbsGOG2a1E&pullRequest=1070

Check warning on line 18 in web/src/ui/pages/s3Explorer/dialogs/S3ProfileDialog.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ3YfPPBqgvhdYcr_ypH&open=AZ3YfPPBqgvhdYcr_ypH&pullRequest=1070

Check warning on line 478 in web/src/core/usecases/s3ProfilesDetailsUiController/decoupledLogic/codeSnippets.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not use nested template literals. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ19CBoXt-zbsGOG2a1H&open=AZ19CBoXt-zbsGOG2a1H&pullRequest=1070

Check warning on line 303 in web/src/ui/pages/s3Explorer/dialogs/S3ProfileDialog.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Promise-returning function provided to return value where a void return was expected. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ19CBhCt-zbsGOG2a0s&open=AZ19CBhCt-zbsGOG2a0s&pullRequest=1070

Check warning on line 89 in web/src/ui/pages/s3Explorer/dialogs/S3ProfileDialog.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use <dialog> instead of the "dialog" role to ensure accessibility across all devices. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ3ZQ6QmSVepKWF9xVna&open=AZ3ZQ6QmSVepKWF9xVna&pullRequest=1070

Check warning on line 16 in web/src/core/usecases/s3ProfilesCreationUiController/thunks.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this "update_existing_profile" label. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ19CBoft-zbsGOG2a1O&open=AZ19CBoft-zbsGOG2a1O&pullRequest=1070

Check warning on line 492 in web/src/core/usecases/s3ProfilesDetailsUiController/decoupledLogic/codeSnippets.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ19CBoXt-zbsGOG2a1K&open=AZ19CBoXt-zbsGOG2a1K&pullRequest=1070

Check warning on line 485 in web/src/core/usecases/s3ProfilesDetailsUiController/decoupledLogic/codeSnippets.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ19CBoXt-zbsGOG2a1I&open=AZ19CBoXt-zbsGOG2a1I&pullRequest=1070
View more details on SonarQubeCloud