fix: Fixes pdf export via cli (on windows) - #235
Conversation
|
Thank you for catching this and submitting a PR. Will get this reviewed and tested for the next release. Thank for your submissions, Ross |
Drop the zero-diagram onAllDiagramsReady guard added here. It is unrelated to showing a bg image behind a bare title slide, and the same export-readiness change is being handled in KovaMD#235. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Thanks for this, the
Thanks, |
|
Hi @RDMillen, thanks for your review feedback. I have adapted the PR in accordance to your comments and hope everything fits to your needs. I have tested it locally on my windows system, and functional-wise it looks good. Best, |
The separating blank line and the safe_write_path doc comment were collapsed onto the closing brace during the review edits. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
All four points look well handled, thank you. I have pushed one tidy-up commit: the blank line and doc comment between Will squash-merge once CI is green so it makes the next release. Thanks, |
Fixes missing images (if used with relative pathes) and diagrams in pdf while using the cli, instead of the export button.
Before
after