[Core] Refactor color_utilities.h to modern C++20#14312
Open
loumalouomega wants to merge 1 commit intomasterfrom
Open
[Core] Refactor color_utilities.h to modern C++20#14312loumalouomega wants to merge 1 commit intomasterfrom
color_utilities.h to modern C++20#14312loumalouomega wants to merge 1 commit intomasterfrom
Conversation
Member
Author
|
@roigcarlo as you said the C++20 support is not full, I will keep this until we update the Ubuntu images |
Member
Author
See #14291 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Modernize
color_utilities.hby replacing the preprocessor-only implementation with typed C++20 constructs (constexpr,std::string_view,std::format), while preserving full backward compatibility through legacy macro aliases.What changed
Before
#defines duplicated across#if !defined(_WIN32)/#elsebranches#define KRED "\x1B[31m")#define FRED(x) KRED x RST), which only works with string literals — notstd::stringorstd::string_viewAfter
Kratos::ColorUtilitiesnamespace with:inline constexpr std::string_viewconstants for all ANSI codes (e.g.kRed,kBold,kReset)[[nodiscard]] inlinefunctions usingstd::formatfor text formatting (e.g.Red(),Bold(),Underline())#if/#elseonly applies once to the constants — no duplication of formatting logicRST,KRED,FRED(x),BOLDFONT(x), etc.) are retained at the bottom and delegate to the namespace, so all existing call sites compile without changesWhy
std::string_viewparams,std::stringreturnsstd::string_viewinput)Kratos::ColorUtilities#if/#elseBOLDFONT(FGRN("text"))works by accidentBold(Green("text"))works by designImpact
KYEL,BOLDFONT(FGRN("CONVERGED")),GetStream() << RST, etc.) continue to compileKratos::ColorUtilities::Green("text")overFGRN("text")🆕 Changelog
color_utilities.hto modern C++20