Skip to content

[minor]staking: add logging target, followup to #1127#1132

Open
Garandor wants to merge 2 commits into
mantafrom
fix_nimbus_round_change2
Open

[minor]staking: add logging target, followup to #1127#1132
Garandor wants to merge 2 commits into
mantafrom
fix_nimbus_round_change2

Conversation

@Garandor
Copy link
Copy Markdown
Contributor

Signed-off-by: Adam Reif Garandor@manta.network## Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor force-pushed the fix_nimbus_round_change2 branch from 5cd5d82 to 0ce414f Compare May 30, 2023 19:44
@Garandor Garandor changed the title add logging target, followup to #1127 [minor]staking: add logging target, followup to #1127 May 30, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 30, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

@ghzlatarev ghzlatarev added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime L-changed Log: Issues and PRs related to changes labels Jul 19, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 19, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 19, 2023

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

@ghzlatarev ghzlatarev self-requested a review July 20, 2023 02:24
@Garandor Garandor removed their assignment Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants