ci(windows): retry submodule fetch on transient github.com 500s#5969
Open
ci(windows): retry submodule fetch on transient github.com 500s#5969
Conversation
…ansient github.com 500s
…flow git submodule loop
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows CI hit transient github.com submodule-clone failures, e.g. run 24845654039:
Six different third-party submodules failed this way within ~25 s (openvdb, parallel-hashmap, tinygltf, tinyxml2, zlib-ng, openvdb/v10) — all HTTP 500s from github.com itself, not an infra issue on our side.
actions/checkout@v6has its own retry logic and the log actually showsFailed to clone 'thirdparty/openvdb/v9/openvdb'. Retry scheduled— but it only retries each submodule once and the second attempt hit the same 500 while github.com was still flaky.Change
Replace
submodules: trueinactions/checkoutwith an explicit retry loop in the next step:Three attempts with a 30 s wait — enough to ride out the ~25 s github.com 500 spike observed in the failing run.
--forcerecovers from any partial clone left by an earlier attempt.--depth=1and-c protocol.version=2match the flagsactions/checkoutitself uses internally.Why not
Wandalen/wretry.actionAn earlier attempt on this PR wrapped the whole
actions/checkoutstep inWandalen/wretry.action@v3.8.0. It triggered astartup_failure— the workflow parser refused to schedule any job. Root cause appears to be thatwretry.action's outer composite-action layer dispatches to an inner_js_actionthat runs onnode20, butactions/checkout@v6usesnode24; the handoff doesn't work and the whole workflow is rejected before any step runs.wretry.actionis thinly maintained and has an open issue (#193) with no ETA for a fix, so a simple in-workflow retry is the right trade.Scope
Only
build-test-windows.yml's checkout area. Other platforms' workflows aren't touched;disable-build-*labels suppress non-windows CI in this PR.Test plan