Skip to content

ci: retry submodule fetch on transient github.com 500s #5969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fedr merged 9 commits into from
Apr 28, 2026
Merged

ci: retry submodule fetch on transient github.com 500s #5969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a57aca2
ci(windows): retry Checkout via Wandalen/wretry.action to tolerate tr…
Fedr Apr 23, 2026
c7920e9
ci(windows): switch checkout retry from Wandalen/wretry to an in-work…
Fedr Apr 23, 2026
89454de
Merge remote-tracking branch 'origin/master' into cicd/retry-windows-…
Fedr Apr 27, 2026
a9cfc67
ci(windows): use scripts/retry.sh for submodule retry
Fedr Apr 27, 2026
80d1f23
ci(windows): restore submodule comments inside run block
Fedr Apr 27, 2026
b4eae54
ci(windows): drop --force from submodule update
Fedr Apr 27, 2026
831b0a5
ci(windows): use `--depth 1` to match master's flag style
Fedr Apr 27, 2026
8b80226
ci: extend retry.sh wrapper to all submodule-checkout steps
Fedr Apr 27, 2026
cbefd97
ci: trigger CI runs on platforms re-enabled by label removal
Fedr Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/build-test-emscripten.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,14 @@ jobs:
# related issue: https://github.com/actions/checkout/issues/1779
export HOME=${RUNNER_TEMP}
git config --global --add safe.directory ${GITHUB_WORKSPACE}
git submodule update --init --depth 1 \
# Retried via retry.sh: submodule endpoints occasionally 500.
bash scripts/retry.sh -- git submodule update --init --depth 1 \
thirdparty/imgui \
thirdparty/parallel-hashmap \
thirdparty/mrbind-pybind11 \
thirdparty/mrbind
# mrbind needs deps/cppdecl; recurse only there
git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl
bash scripts/retry.sh -- git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl

- name: Install thirdparty libs
run: |
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/build-test-linux-vcpkg.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,15 +115,16 @@ jobs:
# related issue: https://github.com/actions/checkout/issues/1779
export HOME=${RUNNER_TEMP}
git config --global --add safe.directory ${GITHUB_WORKSPACE}
git submodule update --init --depth 1 \
# Retried via retry.sh: submodule endpoints occasionally 500.
bash scripts/retry.sh -- git submodule update --init --depth 1 \
thirdparty/imgui \
thirdparty/mrbind-pybind11 \
thirdparty/mrbind \
thirdparty/fastmcpp \
thirdparty/nlohmann-json \
thirdparty/cpp-httplib
# mrbind needs deps/cppdecl; recurse only there
git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl
bash scripts/retry.sh -- git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl

- name: Install MRBind
if: ${{ inputs.mrbind || inputs.mrbind_c }}
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/build-test-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ jobs:
run: |
# Selective init -- parent Checkout drops submodules:true.
# https://github.com/actions/checkout/issues/1779
git submodule update --init --depth 1 \
# Retried via retry.sh: submodule endpoints occasionally 500.
bash scripts/retry.sh -- git submodule update --init --depth 1 \
thirdparty/imgui \
thirdparty/eigen \
thirdparty/parallel-hashmap \
Expand All @@ -96,7 +97,7 @@ jobs:
thirdparty/mrbind \
thirdparty/mrbind-pybind11
# mrbind needs deps/cppdecl; recurse only there
git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl
bash scripts/retry.sh -- git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl

- name: Setup Homebrew prefix and resolve compiler paths
id: setup
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/build-test-ubuntu-arm64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,15 @@ jobs:
# related issue: https://github.com/actions/checkout/issues/1779
export HOME=${RUNNER_TEMP}
git config --global --add safe.directory '*'
git submodule update --init --depth 1 \
# Retried via retry.sh: submodule endpoints occasionally 500.
bash scripts/retry.sh -- git submodule update --init --depth 1 \
thirdparty/imgui \
thirdparty/eigen \
thirdparty/parallel-hashmap \
thirdparty/mrbind-pybind11 \
thirdparty/mrbind
# mrbind needs deps/cppdecl; recurse only there
git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl
bash scripts/retry.sh -- git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl

- name: Install thirdparty libs
run: |
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/build-test-ubuntu-x64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,15 @@ jobs:
# related issue: https://github.com/actions/checkout/issues/1779
export HOME=${RUNNER_TEMP}
git config --global --add safe.directory '*'
git submodule update --init --depth 1 \
# Retried via retry.sh: submodule endpoints occasionally 500.
bash scripts/retry.sh -- git submodule update --init --depth 1 \
thirdparty/imgui \
thirdparty/eigen \
thirdparty/parallel-hashmap \
thirdparty/mrbind-pybind11 \
thirdparty/mrbind
# mrbind needs deps/cppdecl; recurse only there
git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl
bash scripts/retry.sh -- git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl

- name: Install thirdparty libs
run: |
Expand Down
26 changes: 14 additions & 12 deletions .github/workflows/build-test-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,23 +53,25 @@ jobs:
uses: actions/checkout@v6

- name: Checkout third-party submodules
shell: bash
run: |
# Selective init -- parent Checkout drops submodules:true.
# https://github.com/actions/checkout/issues/1779
git submodule update --init --depth 1 `
thirdparty/imgui `
thirdparty/eigen `
thirdparty/parallel-hashmap `
thirdparty/expected `
thirdparty/OpenCTM-git `
thirdparty/laz-perf `
thirdparty/fastmcpp `
thirdparty/nlohmann-json `
thirdparty/cpp-httplib `
thirdparty/mrbind `
# Retried via retry.sh: submodule endpoints occasionally 500.
bash scripts/retry.sh -- git submodule update --init --depth 1 \
thirdparty/imgui \
thirdparty/eigen \
thirdparty/parallel-hashmap \
thirdparty/expected \
thirdparty/OpenCTM-git \
thirdparty/laz-perf \
thirdparty/fastmcpp \
thirdparty/nlohmann-json \
thirdparty/cpp-httplib \
thirdparty/mrbind \
thirdparty/mrbind-pybind11
# mrbind needs deps/cppdecl; recurse only there
Copy link
Copy Markdown
Contributor

@oitel oitel Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this comment go?

Copy link
Copy Markdown
Contributor Author

@Fedr Fedr Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — restored in 80d1f23 right above the cppdecl line.

git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl
bash scripts/retry.sh -- git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl

- name: Get AWS instance type
uses: ./.github/actions/get-aws-instance-type
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/pip-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,13 +107,14 @@ jobs:
git config --global --add safe.directory ${GITHUB_WORKSPACE}/thirdparty/mrbind-pybind11
git config --global --add safe.directory ${GITHUB_WORKSPACE}/thirdparty/mrbind
git config --global --add safe.directory ${GITHUB_WORKSPACE}/thirdparty/mrbind/deps/cppdecl
git submodule update --init --depth 1 \
# Retried via retry.sh: submodule endpoints occasionally 500.
bash scripts/retry.sh -- git submodule update --init --depth 1 \
thirdparty/imgui \
thirdparty/parallel-hashmap \
thirdparty/mrbind-pybind11 \
thirdparty/mrbind
# mrbind needs deps/cppdecl; recurse only there
git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl
bash scripts/retry.sh -- git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl

- name: Install mrbind
# Also print the amount of RAM. If there's not enough RAM, building MRBind bindings can fail. Not doing it in that step, because OOM fails can erase logs from the current step.
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/update-docs-manual.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,15 @@ jobs:
# related issue: https://github.com/actions/checkout/issues/1779
export HOME=${RUNNER_TEMP}
git config --global --add safe.directory '*'
git submodule update --init --depth 1 \
# Retried via retry.sh: submodule endpoints occasionally 500.
bash scripts/retry.sh -- git submodule update --init --depth 1 \
thirdparty/imgui \
thirdparty/eigen \
thirdparty/parallel-hashmap \
thirdparty/mrbind-pybind11 \
thirdparty/mrbind
# mrbind needs deps/cppdecl; recurse only there
git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl
bash scripts/retry.sh -- git -C thirdparty/mrbind submodule update --init --depth 1 deps/cppdecl

- name: Install thirdparty libs
run: |
Expand Down
Loading