Skip to content

Fix bad fd mode error in Reget when file cloning has failed - #5139

Merged
mc-worker merged 1 commit into
MidnightCommander:masterfrom
tuffnatty:fix-file-reopen-mode-in-reget
Aug 16, 2026
Merged

Fix bad fd mode error in Reget when file cloning has failed#5139
mc-worker merged 1 commit into
MidnightCommander:masterfrom
tuffnatty:fix-file-reopen-mode-in-reget

Conversation

@tuffnatty

Copy link
Copy Markdown
Contributor

Proposed changes

  • Don't clear O_WRONLY flag when reopening the destination file in O_APPEND mode.
  • Remove misleading duplicate O_WRONLY setting.

Checklist

  • I have referenced the issue(s) resolved by this PR (if any)
  • I have signed-off my contribution with git commit --amend -s
  • Lint and unit tests pass locally with my changes (make indent && make check)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@github-actions github-actions Bot added needs triage Needs triage by maintainers prio: medium Has the potential to affect progress labels Aug 15, 2026
@github-actions github-actions Bot added this to the Future Releases milestone Aug 15, 2026
@tuffnatty tuffnatty changed the title Fix bad fd mode error in Reget Fix bad fd mode error in Reget when file cloning has failed Aug 15, 2026
…r in reget.

Don't clear O_WRONLY flag when reopening the destination file
in O_APPEND mode.
Remove misleading duplicate O_WRONLY setting.

Signed-off-by: Phil Krylov <phil@krylov.eu>
@aborodin
aborodin force-pushed the fix-file-reopen-mode-in-reget branch from 97cf2a6 to 4fd670e Compare August 16, 2026 09:11
@mc-worker

Copy link
Copy Markdown
Contributor

I just added more info to the commit message.

@mc-worker
mc-worker merged commit 3b41045 into MidnightCommander:master Aug 16, 2026
10 checks passed
@mc-worker

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Needs triage by maintainers prio: medium Has the potential to affect progress

Development

Successfully merging this pull request may close these issues.

File clone VFS operation support on FreeBSD

2 participants