Skip to content

Fix bad fd mode error in Reget when file cloning has failed #5139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mc-worker merged 1 commit into from
Aug 16, 2026
+2 −2
Merged

Fix bad fd mode error in Reget when file cloning has failed #5139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/filemanager/file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2621,7 +2621,7 @@ copy_file_file (file_op_context_t *ctx, const char *src_path, const char *dst_pa
// FICLONERANGE on Linux and copy_file_range(2) on FreeBSD support block-aligned ranges for
// cloning, but for not in O_APPEND mode. Use O_WRONLY + mc_lseek instead as we don't care
// about atomicity in our use cases.
open_flags |= mc_global.vfs.file_cloning ? O_WRONLY : O_APPEND;
open_flags |= mc_global.vfs.file_cloning ? 0 : O_APPEND;
#else
open_flags |= O_APPEND;
#endif
Expand Down Expand Up @@ -2674,7 +2674,7 @@ copy_file_file (file_op_context_t *ctx, const char *src_path, const char *dst_pa
ctx->do_append = TRUE;
mc_close (dest_desc);
dst_status = DEST_NONE;
open_flags = (open_flags & ~O_WRONLY) | O_APPEND;
open_flags |= O_APPEND;
goto open_dest;
}
}
Expand Down
Loading