Skip to content

Numpy array args in register#1227

Closed
StephenThornquist wants to merge 2 commits intoMouseLand:mainfrom
StephenThornquist:numpy_array_register
Closed

Numpy array args in register#1227
StephenThornquist wants to merge 2 commits intoMouseLand:mainfrom
StephenThornquist:numpy_array_register

Conversation

@StephenThornquist
Copy link
Copy Markdown

assign_reg_io accepts Optional[Union[ndarray,BinaryFile]] arguments, but the code checked simply used if arg, which raises an Exception for ndarray.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.32%. Comparing base (be8830d) to head (ecabf91).
⚠️ Report is 228 commits behind head on main.

Files with missing lines Patch % Lines
suite2p/registration/register.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1227      +/-   ##
==========================================
+ Coverage   55.21%   58.32%   +3.10%     
==========================================
  Files          43       47       +4     
  Lines        5055     4434     -621     
==========================================
- Hits         2791     2586     -205     
+ Misses       2264     1848     -416     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StephenThornquist
Copy link
Copy Markdown
Author

Redundant with #1226, closing my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant