Skip to content

Add extra article validation#771

Merged
gunnarvelle merged 4 commits intomasterfrom
add-extra-validation
Sep 30, 2025
Merged

Add extra article validation#771
gunnarvelle merged 4 commits intomasterfrom
add-extra-validation

Conversation

@gunnarvelle
Copy link
Copy Markdown
Member

To nye felttyper, ENUM og TEXT. Einaste forskjellen på String og Text er som en markør for at teksten er fritekst.
https://github.com/NDLANO/Issues/issues/4432

@gunnarvelle gunnarvelle requested a review from a team September 17, 2025 08:10
case object DataResource extends TagAttribute("data-resource")
case object DataResource_Id extends TagAttribute("data-resource_id")
case object DataSize extends TagAttribute("data-size")
case object DataSkipContent extends TagAttribute("data-skip-content")
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ny prop som trengs i NDLANO/frontend-packages#2824

@gunnarvelle gunnarvelle requested a review from jnatten September 23, 2025 07:33
@gunnarvelle gunnarvelle changed the title Add extra validation Add extra article validation Sep 23, 2025
Copy link
Copy Markdown
Contributor

@jnatten jnatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg vet ikke om jeg forstår helt hva TEXT skal brukes til men LGTM 😄

@gunnarvelle
Copy link
Copy Markdown
Member Author

Jeg vet ikke om jeg forstår helt hva TEXT skal brukes til men LGTM 😄

Heng sammen med https://github.com/NDLANO/Issues/issues/4435. Tanken var at det er det samme som string, men er noko som kan inneholde fritekst og dermed må håndteres av en oversettertjeneste.
En eventuell leverandør som overtar for Nynodata kan lese embed-tag-rules.json og dermed vite kva felt den skal ta hensyn til. Mulig det aldri vil tas i bruk.

@jnatten
Copy link
Copy Markdown
Contributor

jnatten commented Sep 29, 2025

Aha forstår!

@gunnarvelle gunnarvelle merged commit 62efe0a into master Sep 30, 2025
17 checks passed
@gunnarvelle gunnarvelle deleted the add-extra-validation branch September 30, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants