Skip to content

Add extra article validation #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gunnarvelle merged 4 commits into from
Sep 30, 2025
Merged

Add extra article validation #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d4abe8
Enum for predefined values, and text as a marker for translatable text
gunnarvelle Sep 17, 2025
38fbe59
Fix validation tests
gunnarvelle Sep 17, 2025
e2f1931
Add test
gunnarvelle Sep 17, 2025
2657fb6
Remove unneccessary config
gunnarvelle Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions article-api/src/test/scala/no/ndla/articleapi/TestData.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ class TestData {
Seq(),
Seq(
VisualElement(
s"<$EmbedTagName data-resource=\"image\" data-resource_id=\"1\" data-size=\"large\" data-align=\"center\" data-alt=\"alt\"></$EmbedTagName>",
s"<$EmbedTagName data-resource=\"image\" data-resource_id=\"1\" data-size=\"full\" data-align=\"center\" data-alt=\"alt\"></$EmbedTagName>",
"en"
)
),
Expand Down Expand Up @@ -302,7 +302,7 @@ class TestData {
val sampleTitle: Title = Title("title", "en")

val visualElement: VisualElement = VisualElement(
s"""<$EmbedTagName data-align="" data-alt="" data-caption="" data-resource="image" data-resource_id="1" data-size=""></$EmbedTagName>""",
s"""<$EmbedTagName data-align="" data-alt="" data-caption="" data-resource="image" data-resource_id="1" data-size="full"></$EmbedTagName>""",
"nb"
)

Expand Down
2 changes: 1 addition & 1 deletion draft-api/src/test/scala/no/ndla/draftapi/TestData.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ object TestData {
val sampleTitle: common.Title = common.Title("title", "en")

val visualElement: common.VisualElement = common.VisualElement(
s"""<$EmbedTagName data-align="" data-alt="" data-caption="" data-resource="image" data-resource_id="1" data-size=""></$EmbedTagName>""",
s"""<$EmbedTagName data-align="" data-alt="" data-caption="" data-resource="image" data-resource_id="1" data-size="full"></$EmbedTagName>""",
"nb"
)

Expand Down
2 changes: 1 addition & 1 deletion ...ingpath-api/src/main/scala/no/ndla/learningpathapi/validation/LearningPathValidator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import no.ndla.mapping.License.getLicense
import no.ndla.common.model.domain.RevisionStatus
import no.ndla.common.model.NDLADate
import no.ndla.common.model.domain.learningpath.Introduction
import no.ndla.validation.HtmlTagRules.{stringToJsoupDocument}
import no.ndla.validation.HtmlTagRules.stringToJsoupDocument
import scala.jdk.CollectionConverters.*

import scala.util.{Failure, Success, Try}
Expand Down
Loading