Make box-shadow be a part of element width for embeds#2423
Draft
Make box-shadow be a part of element width for embeds#2423
Conversation
Contributor
|
Fint dette altså! Men hadde vært veldig greit å få det til for høyde også. Det er tross alt der margin i artikkel faktisk er et ordentlig problem mtp box-shadow :') |
Contributor
Author
Får se litt mer på hvorfor det ikke applyes der! forsåvidt et lite problem at embeds var "utenfor" artikkel-paddingen og da |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dette er en fiks for å tvinge boxShadow: "full" til å ta opp faktisk plass i embeds.
Hentet inspirasjon herfra: https://stackoverflow.com/a/14367262
Syntes dette ser ut til å fungere, prøvde å gjøre tilsvarende for height, men det hadde ingen effekt, som jeg syntes var litt rart ...
Eventuelt er en mulig løsning å lage en wrapper som setter padding tilsvarende plassen box-shadow opptar. Prøvde meg også litt frem med pseudo-element, men det vil ikke fungere med padding utenfra, som er litt av poenget her 😅