Skip to content

Make box-shadow be a part of element width for embeds #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
katrinewi wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Draft

Make box-shadow be a part of element width for embeds #2423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/ndla-ui/src/AudioPlayer/AudioPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ const AudioPlayerWrapper = styled("div", {
boxShadow: "full",
marginBlockEnd: "4xsmall",
overflow: "hidden",
// Include box-shadow in element size
width: "calc(100% - 4px)",
},
});

Expand Down
2 changes: 2 additions & 0 deletions packages/ndla-ui/src/CampaignBlock/CampaignBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ const Container = styled("div", {
tabletWide: {
flexDirection: "row",
},
// Include box-shadow in element size
width: "calc(100% - 4px)",
},
});

Expand Down
2 changes: 2 additions & 0 deletions packages/ndla-ui/src/ContactBlock/ContactBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ const StyledWrapper = styled("div", {
alignItems: "unset",
flexDirection: "row",
},
// Include box-shadow in element size
width: "calc(100% - 4px)",
},
});

Expand Down
2 changes: 2 additions & 0 deletions packages/ndla-ui/src/ResourceBox/ResourceBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ const Container = styled("div", {
gap: "0",
padding: "0",
},
// Include box-shadow in element size
width: "calc(100% - 4px)",
},
});

Expand Down