[test] refactor: move diffusion tests to test_groups directory#3275
[test] refactor: move diffusion tests to test_groups directory#3275huvunvidia wants to merge 3 commits intomainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughTest files are being relocated into a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
/ok to test e244563 |
|
/ok to test 695fb4e |
1 similar comment
|
/ok to test 695fb4e |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@tests/functional_tests/launch_scripts/active/L0_Launch_wan_ckpt_conversion.sh`:
- Line 20: Update the TEST_FILE assignment in the shell script so it points to
the renamed test file: change the value of the TEST_FILE variable in
L0_Launch_wan_ckpt_conversion.sh from
"tests/functional_tests/test_groups/diffusion/wan/test_wan_ckpt_conversion.py"
to "tests/functional_tests/test_groups/diffusion/wan/test_wan_conversion.py" so
pytest can locate the moved test; no other logic needs to change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 20cf0f91-22e2-4170-ab6a-c12a5ea9b8f4
📒 Files selected for processing (4)
tests/functional_tests/launch_scripts/active/L0_Launch_models_flux.shtests/functional_tests/launch_scripts/active/L0_Launch_wan_ckpt_conversion.shtests/functional_tests/test_groups/diffusion/flux/test_flux_conversion.pytests/functional_tests/test_groups/diffusion/wan/test_wan_conversion.py
| export CUDA_VISIBLE_DEVICES="0" | ||
|
|
||
| TEST_FILE="tests/functional_tests/diffusion/wan/test_wan_ckpt_conversion.py" | ||
| TEST_FILE="tests/functional_tests/test_groups/diffusion/wan/test_wan_ckpt_conversion.py" |
There was a problem hiding this comment.
Fix broken WAN test target path after file rename.
Line 20 still targets test_wan_ckpt_conversion.py, but the moved file is test_wan_conversion.py. This will cause pytest file-not-found failures.
🔧 Proposed fix
-TEST_FILE="tests/functional_tests/test_groups/diffusion/wan/test_wan_ckpt_conversion.py"
+TEST_FILE="tests/functional_tests/test_groups/diffusion/wan/test_wan_conversion.py"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| TEST_FILE="tests/functional_tests/test_groups/diffusion/wan/test_wan_ckpt_conversion.py" | |
| TEST_FILE="tests/functional_tests/test_groups/diffusion/wan/test_wan_conversion.py" |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@tests/functional_tests/launch_scripts/active/L0_Launch_wan_ckpt_conversion.sh`
at line 20, Update the TEST_FILE assignment in the shell script so it points to
the renamed test file: change the value of the TEST_FILE variable in
L0_Launch_wan_ckpt_conversion.sh from
"tests/functional_tests/test_groups/diffusion/wan/test_wan_ckpt_conversion.py"
to "tests/functional_tests/test_groups/diffusion/wan/test_wan_conversion.py" so
pytest can locate the moved test; no other logic needs to change.
Summary
test_flux_conversion.pyfromtests/functional_tests/diffusion/flux/totests/functional_tests/test_groups/diffusion/flux/test_wan_ckpt_conversion.pyfromtests/functional_tests/diffusion/wan/totests/functional_tests/test_groups/diffusion/wan/(also renamed totest_wan_conversion.py)test_groupsdirectory structureTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit