Skip to content

[test] refactor: move diffusion tests to test_groups directory#3275

Open
huvunvidia wants to merge 3 commits intomainfrom
huvu/moving_diffusion_tests
Open

[test] refactor: move diffusion tests to test_groups directory#3275
huvunvidia wants to merge 3 commits intomainfrom
huvu/moving_diffusion_tests

Conversation

@huvunvidia
Copy link
Copy Markdown
Contributor

@huvunvidia huvunvidia commented Apr 10, 2026

Summary

  • Moves test_flux_conversion.py from tests/functional_tests/diffusion/flux/ to tests/functional_tests/test_groups/diffusion/flux/
  • Moves test_wan_ckpt_conversion.py from tests/functional_tests/diffusion/wan/ to tests/functional_tests/test_groups/diffusion/wan/ (also renamed to test_wan_conversion.py)
  • No content changes — pure file moves to align with the test_groups directory structure

Test plan

  • Verify tests are discoverable from their new locations
  • Confirm no references to the old paths remain

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Updated test file paths and repository root references for flux and wan conversion tests to align with reorganized test directory structure.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Apr 10, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2026

📝 Walkthrough

Walkthrough

Test files are being relocated into a new test_groups subdirectory structure. Launch scripts are updated to reference the new test file paths, and test modules adjust their root path calculations to account for increased directory depth.

Changes

Cohort / File(s) Summary
Launch Scripts
tests/functional_tests/launch_scripts/active/L0_Launch_models_flux.sh, tests/functional_tests/launch_scripts/active/L0_Launch_wan_ckpt_conversion.sh
Updated pytest invocation and TEST_FILE paths to reference tests relocated to test_groups/diffusion/ subdirectory structure.
Test Modules
tests/functional_tests/test_groups/diffusion/flux/test_flux_conversion.py, tests/functional_tests/test_groups/diffusion/wan/test_wan_conversion.py
Adjusted REPO_ROOT path calculations to use six parent directory traversals instead of five to account for increased nesting depth.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Test Results For Major Changes ⚠️ Warning PR involves major test refactoring but lacks documented test execution results and contains a critical file naming bug in the launch script. Fix launch script reference from test_wan_ckpt_conversion.py to test_wan_conversion.py, execute both launch scripts, and document test results in PR description.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: moving diffusion tests to the test_groups directory structure, which aligns with all four files modified in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch huvu/moving_diffusion_tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@huvunvidia
Copy link
Copy Markdown
Contributor Author

/ok to test e244563

@huvunvidia huvunvidia enabled auto-merge (squash) April 10, 2026 18:34
ko3n1g
ko3n1g previously approved these changes Apr 13, 2026
@ko3n1g ko3n1g added the r0.4.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge. label Apr 13, 2026
@yaoyu-33 yaoyu-33 added area:diffusion DFM module ready-to-merge PR is approved, current, and only waiting for CI to pass before merge labels Apr 13, 2026
@huvunvidia
Copy link
Copy Markdown
Contributor Author

/ok to test 695fb4e

1 similar comment
@huvunvidia
Copy link
Copy Markdown
Contributor Author

/ok to test 695fb4e

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@tests/functional_tests/launch_scripts/active/L0_Launch_wan_ckpt_conversion.sh`:
- Line 20: Update the TEST_FILE assignment in the shell script so it points to
the renamed test file: change the value of the TEST_FILE variable in
L0_Launch_wan_ckpt_conversion.sh from
"tests/functional_tests/test_groups/diffusion/wan/test_wan_ckpt_conversion.py"
to "tests/functional_tests/test_groups/diffusion/wan/test_wan_conversion.py" so
pytest can locate the moved test; no other logic needs to change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 20cf0f91-22e2-4170-ab6a-c12a5ea9b8f4

📥 Commits

Reviewing files that changed from the base of the PR and between ad27e2c and 695fb4e.

📒 Files selected for processing (4)
  • tests/functional_tests/launch_scripts/active/L0_Launch_models_flux.sh
  • tests/functional_tests/launch_scripts/active/L0_Launch_wan_ckpt_conversion.sh
  • tests/functional_tests/test_groups/diffusion/flux/test_flux_conversion.py
  • tests/functional_tests/test_groups/diffusion/wan/test_wan_conversion.py

export CUDA_VISIBLE_DEVICES="0"

TEST_FILE="tests/functional_tests/diffusion/wan/test_wan_ckpt_conversion.py"
TEST_FILE="tests/functional_tests/test_groups/diffusion/wan/test_wan_ckpt_conversion.py"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Fix broken WAN test target path after file rename.

Line 20 still targets test_wan_ckpt_conversion.py, but the moved file is test_wan_conversion.py. This will cause pytest file-not-found failures.

🔧 Proposed fix
-TEST_FILE="tests/functional_tests/test_groups/diffusion/wan/test_wan_ckpt_conversion.py"
+TEST_FILE="tests/functional_tests/test_groups/diffusion/wan/test_wan_conversion.py"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
TEST_FILE="tests/functional_tests/test_groups/diffusion/wan/test_wan_ckpt_conversion.py"
TEST_FILE="tests/functional_tests/test_groups/diffusion/wan/test_wan_conversion.py"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@tests/functional_tests/launch_scripts/active/L0_Launch_wan_ckpt_conversion.sh`
at line 20, Update the TEST_FILE assignment in the shell script so it points to
the renamed test file: change the value of the TEST_FILE variable in
L0_Launch_wan_ckpt_conversion.sh from
"tests/functional_tests/test_groups/diffusion/wan/test_wan_ckpt_conversion.py"
to "tests/functional_tests/test_groups/diffusion/wan/test_wan_conversion.py" so
pytest can locate the moved test; no other logic needs to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:diffusion DFM module full-test-suite r0.4.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge. ready-to-merge PR is approved, current, and only waiting for CI to pass before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants