Skip to content

[test] refactor: move diffusion tests to test_groups directory #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huvunvidia wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[test] refactor: move diffusion tests to test_groups directory #3275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e244563
[test] refactor: move diffusion tests to test_groups directory structure
Apr 10, 2026
09c34f7
edit paths for testing
Apr 14, 2026
695fb4e
Merge remote-tracking branch 'origin/main' into huvu/moving_diffusion…
Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/functional_tests/launch_scripts/active/L0_Launch_models_flux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ export CUDA_VISIBLE_DEVICES="0,1"
uv run coverage run --data-file=/opt/Megatron-Bridge/.coverage --source=/opt/Megatron-Bridge/ --parallel-mode -m pytest \
-o log_cli=true -o log_cli_level=INFO -v -s -x -m "not pleasefixme" --tb=short -rA \
tests/functional_tests/test_groups/diffusion/flux/test_flux_pretrain.py \
tests/functional_tests/diffusion/flux/test_flux_conversion.py
tests/functional_tests/test_groups/diffusion/flux/test_flux_conversion.py
coverage combine -q
2 changes: 1 addition & 1 deletion tests/functional_tests/launch_scripts/active/L0_Launch_wan_ckpt_conversion.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ set -xeuo pipefail

export CUDA_VISIBLE_DEVICES="0"

TEST_FILE="tests/functional_tests/diffusion/wan/test_wan_ckpt_conversion.py"
TEST_FILE="tests/functional_tests/test_groups/diffusion/wan/test_wan_ckpt_conversion.py"
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Fix broken WAN test target path after file rename.

Line 20 still targets test_wan_ckpt_conversion.py, but the moved file is test_wan_conversion.py. This will cause pytest file-not-found failures.

🔧 Proposed fix 
-TEST_FILE="tests/functional_tests/test_groups/diffusion/wan/test_wan_ckpt_conversion.py"
+TEST_FILE="tests/functional_tests/test_groups/diffusion/wan/test_wan_conversion.py"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
TEST_FILE="tests/functional_tests/test_groups/diffusion/wan/test_wan_ckpt_conversion.py"
TEST_FILE="tests/functional_tests/test_groups/diffusion/wan/test_wan_conversion.py"
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In
`@tests/functional_tests/launch_scripts/active/L0_Launch_wan_ckpt_conversion.sh`
at line 20, Update the TEST_FILE assignment in the shell script so it points to
the renamed test file: change the value of the TEST_FILE variable in
L0_Launch_wan_ckpt_conversion.sh from
"tests/functional_tests/test_groups/diffusion/wan/test_wan_ckpt_conversion.py"
to "tests/functional_tests/test_groups/diffusion/wan/test_wan_conversion.py" so
pytest can locate the moved test; no other logic needs to change.

# Run all conversion tests in a single invocation so the class-scoped fixtures
# (toy model creation, HF->Megatron import) are shared across tests.
uv run coverage run \
Expand Down
4 changes: 2 additions & 2 deletions ...ts/diffusion/flux/test_flux_conversion.py → ...ps/diffusion/flux/test_flux_conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
diffusers = pytest.importorskip("diffusers")
FluxTransformer2DModel = diffusers.FluxTransformer2DModel

# Repo root: tests/functional_tests/diffusion/flux -> five parents
REPO_ROOT = Path(__file__).resolve().parent.parent.parent.parent.parent
# Repo root: tests/functional_tests/test_groups/diffusion/flux -> six parents
REPO_ROOT = Path(__file__).resolve().parent.parent.parent.parent.parent.parent
CONVERT_SCRIPT = "examples/diffusion/recipes/flux/conversion/convert_checkpoints.py"


Expand Down
4 changes: 2 additions & 2 deletions ...diffusion/wan/test_wan_ckpt_conversion.py → ...oups/diffusion/wan/test_wan_conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
diffusers = pytest.importorskip("diffusers")
WanTransformer3DModel = diffusers.WanTransformer3DModel

# Repo root: tests/functional_tests/diffusion/wan -> five parents
REPO_ROOT = Path(__file__).resolve().parent.parent.parent.parent.parent
# Repo root: tests/functional_tests/test_groups/diffusion/wan -> six parents
REPO_ROOT = Path(__file__).resolve().parent.parent.parent.parent.parent.parent
CONVERT_SCRIPT = "examples/diffusion/recipes/wan/conversion/convert_checkpoints.py"


Expand Down
Loading