python3: add support for netbsd#344157
Conversation
3a483e8 to
7c1452d
Compare
|
cc @rhelmot |
| # Cross compilation only supports a limited number of "known good" | ||
| # configurations. If you're reading this and it's been a long time | ||
| # since this diff, consider submitting this patch upstream! | ||
| ./freebsd-cross.patch |
There was a problem hiding this comment.
I also made a PR for cpython + freebsd here: python/cpython#124424
|
Have you tested the NetBSD binary actually works? Last time I tried this it didn't, which suggests upstream has this disabled for a reason. |
|
Why does Nix need a cross compiled Python anyway? |
|
We cannot build libpsl -> libcurl without it: I haven't tested the actual interpreter because it's not actually used in nix. |
|
It's the second time this |
|
Before we've talked about not including the Python parts of libpsl when we can't cross compile Python. Can't we do that? |
Sure, but I actually, I don't want this dependency at all in libcurl. As far as I can see, no package really needs it. |
|
Here it's just disabled for cross-compilation: #344211 |
|
Opened an issue instead: #344423 |
Why not just disable it universally then? |
|
I did this here: #344209 feel free to pick or not. |
|
I don't understand from that what it's needed for. |
Description of changes
This is needed for NixOS/nix#11566
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.