Skip to content

[Backport release-25.05] electron_34-bin: mark as insecure because it's EOL; electron-source.electron_34: remove as it's EOL#421203

Merged
wolfgangwalther merged 2 commits intorelease-25.05from
backport-419903-to-release-25.05
Jul 3, 2025
Merged

[Backport release-25.05] electron_34-bin: mark as insecure because it's EOL; electron-source.electron_34: remove as it's EOL#421203
wolfgangwalther merged 2 commits intorelease-25.05from
backport-419903-to-release-25.05

Conversation

@nixpkgs-ci
Copy link
Copy Markdown
Contributor

@nixpkgs-ci nixpkgs-ci Bot commented Jun 30, 2025

Bot-based backport to release-25.05, triggered by a label in #419903.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-committer, if you find that it is not acceptable, leave a comment.

@nixpkgs-ci nixpkgs-ci Bot added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jun 30, 2025
@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request Jun 30, 2025
Merged
22 tasks
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 4.workflow: backport This targets a stable branch labels Jun 30, 2025
@TomaSajt
Copy link
Copy Markdown
Contributor

TomaSajt commented Jun 30, 2025 •
edited by wolfgangwalther
Loading

Backport PRs of dependent packages:

This was referenced Jul 1, 2025
Merged
Merged
Merged
Merged
Merged
teutat3s
teutat3s approved these changes Jul 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@teutat3s teutat3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All PRs with fixes for the main PR have been backported. Let's get this merged as well.

@teutat3s teutat3s added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 2, 2025
@nixpkgs-ci nixpkgs-ci Bot removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Jul 2, 2025
@wolfgangwalther
Copy link
Copy Markdown
Contributor

wolfgangwalther commented Jul 2, 2025 •
edited
Loading

For my understanding, what does that do to deltachat-desktop and mattermost-desktop, which are in the list above, but without PRs? Did they not need a fix or will they be broken this way?

Edit: Added #421888 for mattermost-desktop.

@teutat3s
Copy link
Copy Markdown
Member

teutat3s commented Jul 3, 2025

For my understanding, what does that do to deltachat-desktop and mattermost-desktop, which are in the list above, but without PRs? Did they not need a fix or will they be broken this way?

Edit: Added #421888 for mattermost-desktop.

The effect is described in the original PR: #419903
It boils down to users having to opt-in to allow an insecure package.

@wolfgangwalther
Copy link
Copy Markdown
Contributor

wolfgangwalther commented Jul 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 421203
Commit: f42c64335678683acaa28583e887dd31e09f3509

x86_64-linux

⏩ 3 packages marked as broken and skipped:
  • deltachat-desktop
  • electron_34
  • podman-desktop
✅ 9 packages built:
  • appium-inspector
  • bitwarden-desktop
  • breitbandmessung
  • lx-music-desktop
  • mattermost-desktop
  • rstudio
  • rstudioWrapper
  • webcord-vencord
  • whalebird

@wolfgangwalther wolfgangwalther merged commit 7896c51 into release-25.05 Jul 3, 2025
32 of 33 checks passed
@wolfgangwalther wolfgangwalther deleted the backport-419903-to-release-25.05 branch July 3, 2025 12:39
@kachick kachick mentioned this pull request Jul 5, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teutat3s teutat3s teutat3s approved these changes

@TomaSajt TomaSajt Awaiting requested review from TomaSajt

@yayayayaka yayayayaka Awaiting requested review from yayayayaka

@yuyuyureka yuyuyureka Awaiting requested review from yuyuyureka

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 4.workflow: backport This targets a stable branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomaSajt @wolfgangwalther @teutat3s