podman-desktop: bump electron and pnpm version with adjusted updateScript#407982
podman-desktop: bump electron and pnpm version with adjusted updateScript#407982khaneliman merged 2 commits intoNixOS:masterfrom
Conversation
Upstream v1.18.0 updated the versions of pnpm and electron, but these changes were not reflected in the nixpkgs definition at the time of 2d72c6e. This commit aligns the versions accordingly. * pnpm: podman-desktop/podman-desktop@b56fde3 * electron: podman-desktop/podman-desktop@47b8f00
e1eae96 to
32146f4
Compare
|
Intentionally omitted When I run Therefore, I only included the results from my NixOS machine and the Darwin GHA runners.
|
|
Thank you for the update. I should be more cautious about upstream bumps. Thanks for including the update script - confirmed it works as intended. Also confirmed that the app still works on Darwin.
|
|
Thank you for reviewing and merging! |
|
Since backporting the Electron 34 EOL PR #421203, podman-desktop has been raising an error. Therefore, is it reasonable to also backport this PR? podman-desktop on nixos-25.05 remains on version 1.18.1 |
|
Successfully created backport PR for |
This PR is a follow-up to recent updates: #399934, #406299
Related commits in upstream
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.