prefetch-npm-deps: add support for npm-shrinkwrap.json#460084
Merged
doronbehar merged 1 commit intoNixOS:staging-nextfrom Nov 10, 2025
Merged
prefetch-npm-deps: add support for npm-shrinkwrap.json#460084doronbehar merged 1 commit intoNixOS:staging-nextfrom
npm-shrinkwrap.json#460084doronbehar merged 1 commit intoNixOS:staging-nextfrom
Conversation
13 tasks
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
doronbehar
approved these changes
Nov 9, 2025
Contributor
doronbehar
left a comment
doronbehar
left a comment
There was a problem hiding this comment.
LGTM, and I tested it fixes the example failure of sitespeed-io.
nixpkgs-ci
Bot
added
the
12.approvals: 1
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
IIUC the failures found by the merge queue have been solved by merging #460315. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
NixOS:staging-next
with commit Nov 10, 2025
9a5bf49
57 of 59 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Fixes: #443832 (comment)
Tested that I was able to reproduce the issue by setting
npmDepsHashto an empty string inpkgs/by-name/ar/ares-cli/package.nixonstaging-next; with this change I can confirm it's able to generate the correct hash.Not sure if
staging-nextis the correct branch, it looks like it does not generate much rebuilds.passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.