Skip to content

prefetch-npm-deps: add support for npm-shrinkwrap.json #460084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doronbehar merged 1 commit into from
Nov 10, 2025
Merged

prefetch-npm-deps: add support for npm-shrinkwrap.json #460084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions pkgs/build-support/node/fetch-npm-deps/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,20 +242,24 @@
buildPhase = ''
runHook preBuild

if [[ ! -e package-lock.json ]]; then
if [[ -f npm-shrinkwrap.json ]]; then
local -r srcLockfile="npm-shrinkwrap.json"
elif [[ -f package-lock.json ]]; then
local -r srcLockfile="package-lock.json"
else
echo
echo "ERROR: The package-lock.json file does not exist!"
echo "ERROR: No lock file!"
echo
echo "package-lock.json is required to make sure that npmDepsHash doesn't change"
echo "when packages are updated on npm."
echo "package-lock.json or npm-shrinkwrap.json is required to make sure"
echo "that npmDepsHash doesn't change when packages are updated on npm."
echo
echo "Hint: You can copy a vendored package-lock.json file via postPatch."
echo

exit 1
fi

prefetch-npm-deps package-lock.json $out
prefetch-npm-deps $srcLockfile $out

runHook postBuild
'';
Expand Down
Loading