chore: Fix netlify deploy.#6047
Merged
Merged
Conversation
❌ Deploy Preview for ohif-dev failed. Why did it fail? →
|
📝 WalkthroughWalkthroughThis PR adds a single dependency resolution entry to ChangesBabel Helper Plugin Dependency Resolution
🎯 2 (Simple) | ⏱️ ~5 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Actionable comments posted: 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Netlify was not auto-deploying to viewer-dev. The reason from Claude being...
Changes & Results
Added resolution for "@babel/helper-create-class-features-plugin": "7.29.7".
Testing
Automated tests should pass and Netlify viewer-dev deploy should work.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Summary by CodeRabbit
Greptile Summary
This PR fixes Netlify deploy failures by adding a Yarn
resolutionsentry for@babel/helper-create-class-features-plugin@7.29.7, forcing all dependents to resolve to the same version instead of splitting between 7.27.1 and 7.28.6. Bothyarn.lockandbun.lockare updated to reflect the unified resolution.package.json: Adds"@babel/helper-create-class-features-plugin": "7.29.7"underresolutionsto prevent Yarn 1's hoisting from picking the older 7.27.1 copy at the top level.yarn.lock: Collapses the two separate plugin entries into a single 7.29.7 block covering all semver ranges, with all sub-dependencies brought to matching 7.29.x versions.bun.lock: Mirrors the same plugin resolution update and also bumps all@ohif/*workspace packages from3.13.0-beta.84to3.13.0-beta.85(with peerDependencies aligned from beta.83 → beta.85).Confidence Score: 5/5
Targeted dependency resolution fix with no logic changes; safe to merge.
The change is limited to a single new resolutions entry in package.json and the corresponding lock-file updates. The root cause is well-diagnosed (Yarn 1 hoisting a stale version of the helper plugin), the fix follows the standard Yarn resolutions pattern, and both lock files have been regenerated consistently. There are no code logic changes.
No files require special attention.
Important Files Changed
@babel/helper-create-class-features-plugin: 7.29.7to Yarn resolutions to force a single unified version and eliminate the version-split that caused Netlify build failures.@babel/helper-create-class-features-pluginentries (7.27.1 and 7.28.6) into one at 7.29.7, correctly reflecting the new resolution; also pulls in matching 7.29.x sub-dependencies.@babel/helper-create-class-features-pluginresolution to 7.29.7 and bumps all@ohif/*workspace packages from beta.84 → beta.85 (peerDependencies also aligned from beta.83 → beta.85).Reviews (1): Last reviewed commit: "chore: Fix netlify deploy." | Re-trigger Greptile