Skip to content

chore: Fix netlify deploy.#6047

Merged
jbocce merged 1 commit into
OHIF:masterfrom
jbocce:fix/netlify-deploy
May 28, 2026
Merged

chore: Fix netlify deploy.#6047
jbocce merged 1 commit into
OHIF:masterfrom
jbocce:fix/netlify-deploy

Conversation

@jbocce
Copy link
Copy Markdown
Collaborator

@jbocce jbocce commented May 28, 2026

Context

Netlify was not auto-deploying to viewer-dev. The reason from Claude being...

 That commit (on May 15, 2026) bumped @babel/preset-env from 7.28.0 → 7.29.5 in the root package.json. The new preset pulled in @babel/plugin-transform-class-static-block@7.28.6, which calls buildNamedEvaluationVisitor from @babel/helper-create-class-features-plugin. That function only exists in 7.28.x of the helper.

  Your current yarn.lock resolved the helper to two versions side-by-side (yarn.lock:194 and yarn.lock:207):

  - 7.28.6 for ^7.18.6 / ^7.21.0 / ^7.28.6
  - 7.27.1 for the bare ^7.27.1 requesters

  On Netlify, --pure-lockfile installs exactly that lock. Yarn 1 hoists 7.27.1 to the top-level node_modules/@babel/helper-create-class-features-plugin/ (because more callers want ^7.27.1), and the newer plugin at the top level resolves up to that older copy → buildNamedEvaluationVisitor is not a function.

Changes & Results

Added resolution for "@babel/helper-create-class-features-plugin": "7.29.7".

Testing

Automated tests should pass and Netlify viewer-dev deploy should work.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Summary by CodeRabbit

  • Chores
    • Pinned a build tool dependency version to ensure consistent builds across environments.

Review Change Stack

Greptile Summary

This PR fixes Netlify deploy failures by adding a Yarn resolutions entry for @babel/helper-create-class-features-plugin@7.29.7, forcing all dependents to resolve to the same version instead of splitting between 7.27.1 and 7.28.6. Both yarn.lock and bun.lock are updated to reflect the unified resolution.

  • package.json: Adds "@babel/helper-create-class-features-plugin": "7.29.7" under resolutions to prevent Yarn 1's hoisting from picking the older 7.27.1 copy at the top level.
  • yarn.lock: Collapses the two separate plugin entries into a single 7.29.7 block covering all semver ranges, with all sub-dependencies brought to matching 7.29.x versions.
  • bun.lock: Mirrors the same plugin resolution update and also bumps all @ohif/* workspace packages from 3.13.0-beta.84 to 3.13.0-beta.85 (with peerDependencies aligned from beta.83 → beta.85).

Confidence Score: 5/5

Targeted dependency resolution fix with no logic changes; safe to merge.

The change is limited to a single new resolutions entry in package.json and the corresponding lock-file updates. The root cause is well-diagnosed (Yarn 1 hoisting a stale version of the helper plugin), the fix follows the standard Yarn resolutions pattern, and both lock files have been regenerated consistently. There are no code logic changes.

No files require special attention.

Important Files Changed

Filename Overview
package.json Adds @babel/helper-create-class-features-plugin: 7.29.7 to Yarn resolutions to force a single unified version and eliminate the version-split that caused Netlify build failures.
yarn.lock Consolidates the two previous @babel/helper-create-class-features-plugin entries (7.27.1 and 7.28.6) into one at 7.29.7, correctly reflecting the new resolution; also pulls in matching 7.29.x sub-dependencies.
bun.lock Updates @babel/helper-create-class-features-plugin resolution to 7.29.7 and bumps all @ohif/* workspace packages from beta.84 → beta.85 (peerDependencies also aligned from beta.83 → beta.85).

Reviews (1): Last reviewed commit: "chore: Fix netlify deploy." | Re-trigger Greptile

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 28, 2026

Deploy Preview for ohif-dev failed. Why did it fail? →

Name Link
🔨 Latest commit 0f73dfa
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/6a188dab396e280008ea717d

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

📝 Walkthrough

Walkthrough

This PR adds a single dependency resolution entry to package.json, pinning @babel/helper-create-class-features-plugin to version 7.29.7 to ensure consistent behavior across environments and dependency resolution chains.

Changes

Babel Helper Plugin Dependency Resolution

Layer / File(s) Summary
Babel helper plugin version pinning
package.json
Added @babel/helper-create-class-features-plugin@7.29.7 to the resolutions field to lock this transitive dependency version.

🎯 2 (Simple) | ⏱️ ~5 minutes

🐰 A helper plugin tamed with care,

Version locked for builds so fair,

Babel's dance now smooth and clear,

Consistency blooms far and near! 🌱

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title 'chore: Fix netlify deploy.' is directly related to the main change—adding a Babel dependency resolution to fix a Netlify deployment issue. It clearly summarizes the primary objective using semantic-release format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description is comprehensive and follows the template structure with all major sections completed: Context clearly explains the Netlify deployment failure and root cause, Changes & Results documents the dependency resolution fix, Testing describes validation approach, and the Checklist is fully marked.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@jbocce jbocce merged commit ff3e855 into OHIF:master May 28, 2026
5 of 9 checks passed
@jbocce jbocce deleted the fix/netlify-deploy branch May 28, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant