Roshini Seelamsetty : fix: implement permissions logic for task extension count visibility#2181
Open
roshini1212 wants to merge 1 commit into
Open
Roshini Seelamsetty : fix: implement permissions logic for task extension count visibility#2181roshini1212 wants to merge 1 commit into
roshini1212 wants to merge 1 commit into
Conversation
|
nathanah
approved these changes
May 2, 2026
Comment on lines
+17
to
+18
| (await hasPermission(requestor, 'seeNumberOfTimesTimeAdded')) || | ||
| (await hasPermission(requestor, 'viewTaskExtensionCount')); |
Contributor
There was a problem hiding this comment.
Suggested change
| (await hasPermission(requestor, 'seeNumberOfTimesTimeAdded')) || | |
| (await hasPermission(requestor, 'viewTaskExtensionCount')); | |
| (await hasPermission(requestor, 'seeNumberOfTimesTimeAdded')); |
Is viewTaskExtensionCount implemented as something else or a different name for what ended up as seeNumberOfTimesTimeAdded? I don't see it used anywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Related PRS (if any):
This backend #2181 PR is related to the #5199 PR Frontend.
To test this backend #2181 PR you need to checkout the #5199 PR frontend.
…
Main changes explained:
How to test:
Screenshots or videos of changes:
Note:
Requires the frontend PR #5199 to be checked out for full end-to-end testing.