Roshini Seelamsetty : Add permissions logic for task extension count visibility#5199
Open
roshini1212 wants to merge 1 commit into
Open
Roshini Seelamsetty : Add permissions logic for task extension count visibility#5199roshini1212 wants to merge 1 commit into
roshini1212 wants to merge 1 commit into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
one-community
added
the
High Priority - Please Review First
nathanah
requested changes
May 2, 2026
Contributor
nathanah
left a comment
nathanah
left a comment
There was a problem hiding this comment.
Just needs a small change to remove the redundant role check.
Comment on lines
+151
to
+153
| const isAllowedToSeeDeadlineCount = | ||
| rolesAllowedToSeeDeadlineCount.includes(userRole) || | ||
| dispatch(hasPermission('seeNumberOfTimesTimeAdded')); |
Contributor
There was a problem hiding this comment.
Suggested change
| const isAllowedToSeeDeadlineCount = | |
| rolesAllowedToSeeDeadlineCount.includes(userRole) || | |
| dispatch(hasPermission('seeNumberOfTimesTimeAdded')); | |
| const isAllowedToSeeDeadlineCount = dispatch(hasPermission('seeNumberOfTimesTimeAdded')); |
hasPermission() checks role permissions, which it looks like you set up on the backend through createInitialPermissions.js. Checking against this hard-coded array can potentially create conflicting sources of truth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related PRS (if any):
This frontend PR is related to the # 2181 backend PR: OneCommunityGlobal/HGNRest#2181
…
Main changes explained:
How to test:
Screenshots or videos of changes:
Note:
Requires the backend PR #2181 to be checked out for full end-to-end testing: OneCommunityGlobal/HGNRest#2181