Skip to content

Roshini Seelamsetty : Add permissions logic for task extension count visibility #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roshini1212 wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Roshini Seelamsetty : Add permissions logic for task extension count visibility #5199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/PermissionsManagement/Permissions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,11 @@
"label": "Unassign Team Members from Tasks",
"key": "deleteDashboardTask",
"description": "Gives the user permission to UNASSIGN tasks from only their TEAM members through the Dashboard -> task -> red X."
},
{
"label": "See # of Times Time Added to Task",
"key": "seeNumberOfTimesTimeAdded",
"description": "Gives the user permission to see how many times a time entry has been added to a task. \"Admin/Owner Login\" -> \"Dashboard\" -> \"Tasks tab\" -> \"Task Details\" -> \"# of Times Time Added\""
}
]
}
Expand Down
4 changes: 3 additions & 1 deletion src/components/TeamMemberTasks/TeamMemberTask.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,9 @@ const TeamMemberTask = React.memo(
const rolesAllowedToSeeDeadlineCount = ['Manager', 'Mentor', 'Administrator', 'Owner'];
const isAllowedToResolveTasks =
rolesAllowedToResolveTasks.includes(userRole) || dispatch(hasPermission('resolveTask'));
const isAllowedToSeeDeadlineCount = rolesAllowedToSeeDeadlineCount.includes(userRole);
const isAllowedToSeeDeadlineCount =
rolesAllowedToSeeDeadlineCount.includes(userRole) ||
dispatch(hasPermission('seeNumberOfTimesTimeAdded'));
Comment on lines +151 to +153
Copy link
Copy Markdown
Contributor

@nathanah nathanah May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const isAllowedToSeeDeadlineCount =
rolesAllowedToSeeDeadlineCount.includes(userRole) ||
dispatch(hasPermission('seeNumberOfTimesTimeAdded'));
const isAllowedToSeeDeadlineCount = dispatch(hasPermission('seeNumberOfTimesTimeAdded'));

hasPermission() checks role permissions, which it looks like you set up on the backend through createInitialPermissions.js. Checking against this hard-coded array can potentially create conflicting sources of truth.


const canGetWeeklySummaries = dispatch(hasPermission('getWeeklySummaries'));
const canSeeReports =
Expand Down
Loading