Skip to content

Adopt schema change for ctrace-refwith type: dwt - #30

Merged
jreineckearm merged 3 commits into
mainfrom
symbol-address
Aug 13, 2026
Merged

Adopt schema change for ctrace-refwith type: dwt#30
jreineckearm merged 3 commits into
mainfrom
symbol-address

Conversation

@JonatanAntoni

@JonatanAntoni JonatanAntoni commented Aug 6, 2026

Copy link
Copy Markdown
Member

Contributes to #27

  - ctrace-ref: data#1
    type: dwt
    address: <fixed or resolved symbol address>
    size: <fixed or resolved symbol size>
    symbol-file: <symbol file if used>
    data-type: <symbol type>

```
  - ctrace-ref: data#1
    type: dwt
    address: <fixed or resolved symbol address>
    size: <fixed or resolved symbol size>
    symbol-file: <symbol file if used>
    data-type: <symbol type>
```
@jreineckearm

jreineckearm commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Tested briefly. This should keep us going. Some adjustments needed/to be considered as we go forward. Split into things that would be awesome to get fixed now (or soon), and things that would take a little longer.

Action now if possible:

  • I get data-type = unsigned int for osRtxInfo.kernel.tick. Should be unsigned.

Action later:

  • If I use an object like osRtxInfo then I get data-type = object. Should default to unsigned but not yet documented. Leave as is for now in case I can think of why object as data-type would become useful.
  • If I enter a size of 6 then I get the error: error: Cortex-M7 DWT-Unit data.size must be a power of two. In future we must auto-expand to satisfy the HW needs and write a warning. See Unexpected output for data: entry with size #19 .

@qltysh

qltysh Bot commented Aug 6, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/pyts/coresight/generator.py100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@JonatanAntoni JonatanAntoni changed the title Adopt schema change for ctrace-refwith `type: dwt´ Adopt schema change for ctrace-refwith type: dwt Aug 6, 2026
@jreineckearm

Copy link
Copy Markdown
Contributor

Changes in Open-CMSIS-Pack/cmsis-toolbox#669 got merged.
Merging this Draft, to keep up with the spec. Tested field changes with current ctrace version which handles them gracefully for CSV.

@jreineckearm
jreineckearm marked this pull request as ready for review August 13, 2026 15:24

@jreineckearm jreineckearm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment.

@jreineckearm
jreineckearm merged commit db4b003 into main Aug 13, 2026
13 of 14 checks passed
@jreineckearm
jreineckearm deleted the symbol-address branch August 13, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants