Skip to content

Enhance dwarf reader to return canonical type names - #31

Merged
jreineckearm merged 5 commits into
mainfrom
canonical-data-types
Aug 13, 2026
Merged

Enhance dwarf reader to return canonical type names#31
jreineckearm merged 5 commits into
mainfrom
canonical-data-types

Conversation

@JonatanAntoni

Copy link
Copy Markdown
Member

Instead of language specific symbol type from DW_AT_name a canonical type name is decoded from DW_AT_encoding

Contributes to #27
Addresses review feedback in #30

Instead of language specific symbol type from `DW_AT_name` a canonical type name is decoded from `DW_AT_encoding`
@JonatanAntoni
JonatanAntoni marked this pull request as draft August 6, 2026 11:42
@qltysh

qltysh Bot commented Aug 6, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.8%.

Modified Files with Diff Coverage (5)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
src/pyts/elf/dwarf.py100.0%
Coverage rating: A Coverage rating: A
src/pyts/elf/model.py100.0%
Coverage rating: A Coverage rating: A
src/pyts/elf/resolver.py100.0%
Coverage rating: B Coverage rating: B
src/pyts/elf/symbol_table.py100.0%
Coverage rating: C Coverage rating: B
src/pyts/elf/dwarf_members.py100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh

qltysh Bot commented Aug 6, 2026

Copy link
Copy Markdown

All good ✅

Comment thread src/pyts/elf/dwarf.py

@jreineckearm jreineckearm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected with latest changes. Would wait with merging though until spec for data-type is approved.

@jreineckearm jreineckearm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closer to spec despite seeing other than the three specified types. Merging to continue with E2E flow testing. Will capture types as separate issue.

@jreineckearm
jreineckearm marked this pull request as ready for review August 13, 2026 15:31
@jreineckearm
jreineckearm merged commit 3bff0f1 into main Aug 13, 2026
13 of 14 checks passed
@jreineckearm
jreineckearm deleted the canonical-data-types branch August 13, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants