Project convention updates [Rebase & FF]#1469
Merged
makubacki merged 4 commits intoOpenDevicePartnership:mainfrom Apr 16, 2026
Merged
Project convention updates [Rebase & FF]#1469makubacki merged 4 commits intoOpenDevicePartnership:mainfrom
makubacki merged 4 commits intoOpenDevicePartnership:mainfrom
Conversation
Move x64/mod.rs to x64.rs and aarch64/mod.rs to aarch64.rs to follow the project convention of using named module files instead of mod.rs. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Rename mod.rs to tests_root.rs and update the test entry point to use a #[path] attribute redirect, eliminating mod.rs while preserving the existing module hierarchy and crate-level import paths. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
We prefer expect() in production code to provide more context in the event of an error. Add descriptive messages to unwrap() calls in: - rbt.rs: RBT rebalancing where sibling/parent nodes are guaranteed to exist by the algorithm invariants - x64/runtime_function.rs: PE .pdata chunk reads validated by preceding size checks - aarch64/runtime_function.rs: same pattern for AArch64 .pdata parsing Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Add #![deny(missing_docs)] to component crate lib.rs files to enforce documentation requirements on public items. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Contributor
✅ QEMU Validation PassedAll QEMU validation jobs completed successfully.
Workflow run: https://github.com/OpenDevicePartnership/patina/actions/runs/24527974917 Boot Time to EFI Shell
Dependencies
This comment was automatically generated by the Patina QEMU PR Validation Post workflow. |
github-actions
Bot
added
the
impact:non-functional
vineelko
approved these changes
Apr 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
os-d
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A few miscellaneous changes to update code not complying with the project instructions in #1460.
patina_stacktrace: Replace mod.rs with named module files
Move x64/mod.rs to x64.rs and aarch64/mod.rs to aarch64.rs to follow
the project convention of using named module files instead of mod.rs.
patina_mm: Replace mod.rs in integration test with a named module file
Rename mod.rs to tests_root.rs and update the test entry point to use
a #[path] attribute redirect, eliminating mod.rs while preserving the
existing module hierarchy and crate-level import paths.
Replace unwrap() with expect() in a few locations
We prefer expect() in production code to provide more context in the
event of an error.
Add descriptive messages to unwrap() calls in:
to exist by the algorithm invariants
preceding size checks
components: Enforce missing_docs lint in all component crates
Add #![deny(missing_docs)] to component crate lib.rs files to enforce
documentation requirements on public items.
How This Was Tested
cargo make allIntegration Instructions