Conversation
|
Note, I renamed. I think this is narinfc docs. |
|
@vololand can you please remove the submodule updates from this branch? |
f519c87 to
c0bc7d4
Compare
| @@ -0,0 +1,225 @@ | |||
| # VOLOLAND NarinFC-H7 | |||
|
|
|||
There was a problem hiding this comment.
What is the first version that this was added to? I.e. PX4 v1.17?
There was a problem hiding this comment.
What is the first version that this was added to? I.e. PX4 v1.17?
@hamishwillee
I'm sorry for the late reply.
- boards: add NarinFC-H7
· boards: add NarinFC-H7 #25362 - docs: add narinfc_h7 documentation
· https://github.com/PX4/PX4-Autopilot/pull/26542/commits
I remember it was PX4 1.16 when I was working on it....
| **Interfaces** | ||
|
|
||
| - 14 PWM servo outputs | ||
| - Support multiple RC inputs (SBus / CPPM / DSM) |
There was a problem hiding this comment.
How is the RC IN input wired? Is this connected to an IO board or directly connected to the FMU? This affects what drivers can be used.
There was a problem hiding this comment.
@hamishwillee
I'm sorry for the late reply.
directly connected to the FMU.
hamishwillee
left a comment
There was a problem hiding this comment.
Thank you
1.
2. I have subedited to improve layout and follow common conventions for these docs - such as smaller images in lower case, prefixing names with manufacturer.
3. I have added this to SUMMARY.md so it appears in sidebar
4. Have added to manuf. supported boards and added appropriate headers
For you to do:
- There are unrelated changes in
Tools/simulation/gz- please remove - There are some inline questions
@hamishwillee
|
|
@vololand YOur force push removed all the changes I made. |
|
|
OK, are you "good enough" to push them back? If not I will try to get them back tomorrow. |
@hamishwillee |
|
@vololand I have updated the documents... again. Please CHECK them since I made some significant changes to match to style. |
|  | ||
|
|
||
| - 2.54mm pitch DuPont connector | ||
| - RC_IN: Remote control receiver |
There was a problem hiding this comment.
So this is wired to FMU and enabled via RC_INPUT right?
There was a problem hiding this comment.
PS, please sync up to the changes I have made here. If you swamp away my changes again I give up.
Add hardware documentation for the VOLOLAND NarinFC-H7 flight controller including pinouts, serial port mapping, PWM output groups, and analog inputs. Fix version badge to v1.17 and clarify RC_IN is wired directly to FMU via RC_INPUT driver. Based on work by @vololand and @hamishwillee from PR #26542. Signed-off-by: Ramon Roche <mrpollo@gmail.com>
|
Superseded by #26721. That PR contains only the documentation changes with all unrelated submodule modifications removed, and addresses the review feedback (version badge fixed to v1.17, RC_IN wiring details added). @vololand @hamishwillee please review the new PR. |
|
closed by #26721 |
New Crowdin translations - en