EX-3143: Declare proto3 optional support in protoc-gen-cruxclient - #155
Open
Michael Gunawan (scmichaelg) wants to merge 1 commit into
Open
EX-3143: Declare proto3 optional support in protoc-gen-cruxclient#155Michael Gunawan (scmichaelg) wants to merge 1 commit into
Michael Gunawan (scmichaelg) wants to merge 1 commit into
Conversation
Without this, buf/protoc emits a warning for every .proto file using proto3 optional fields, and may refuse to invoke the plugin in strict mode.
This was referenced Mar 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
GetSupportedFeatures()override to declareFEATURE_PROTO3_OPTIONALsupport in the cruxclient protoc plugin.EX-3143
Problem description
When using
protoc-gen-cruxclientwith proto files that useoptionalfields (proto3 optional), buf/protoc emits warnings like:The fix is a one-line override in the Generator class to declare the plugin supports this feature.