refactor: defer handling of prepareForCompletion violations to submission#545
Merged
kieran-osgood-shopify merged 1 commit intomainfrom Mar 27, 2026
Conversation
This was referenced Mar 27, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| payload: StorefrontAPI.CartPrepareForCompletionPayload, | ||
| shippingCountry: String?, | ||
| requiredContactFields: Set<PKContactField>? | ||
| shippingCountry _: String?, |
Contributor
Author
There was a problem hiding this comment.
I'm purposefully not fully undoing this path entirely as I know this will be useful again when we improve the UX to surface these errors agin
kieran-osgood-shopify
changed the base branch from
cx-migrate-accelerated-checkout-2025-07
to
graphite-base/545
kieran-osgood-shopify
force-pushed
the
kieran-osgood/03-27-refactordeferhandlingofprepareforcompletionviolationstosubmission
branch
from
a45ff05 to
f66bca8
Compare
kieran-osgood-shopify
force-pushed
the
graphite-base/545
branch
from
37178a2 to
3c029bc
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/03-27-refactordeferhandlingofprepareforcompletionviolationstosubmission
branch
from
f66bca8 to
5f1dbba
Compare
markmur
reviewed
Mar 27, 2026
Comment on lines
-4
to
12
| "identity" : "apollo-ios", | ||
| "kind" : "remoteSourceControl", | ||
| "location" : "https://github.com/apollographql/apollo-ios.git", | ||
| "state" : { | ||
| "revision" : "1abd62f6cbc8c1f4405919d7eb6cd8e96967b07c", | ||
| "version" : "1.25.3" | ||
| } | ||
| }, | ||
| { |
Contributor
Author
There was a problem hiding this comment.
Meant to add a comment, I'm not sure why this is happening but its occurring on another branch too where I'm bumping to v2, sample app still continues to run so I'm searching for a reason why
markmur
approved these changes
Mar 27, 2026
kiftio
approved these changes
Mar 27, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/03-27-refactordeferhandlingofprepareforcompletionviolationstosubmission
branch
from
5f1dbba to
71c866e
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/03-27-refactordeferhandlingofprepareforcompletionviolationstosubmission
branch
from
71c866e to
6f01f98
Compare
kieran-osgood-shopify
deleted the
kieran-osgood/03-27-refactordeferhandlingofprepareforcompletionviolationstosubmission
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Realised during testing the downstream stack that there is more to be done here to handle violations early, and we're at risk of introducing regressions
This PR removes the filtering entirely, restoring previous behaviour of "prepare" always continuing, and violations being returned back to the user at 'submit' stage
Before you merge
Important
Releasing a new version of the kit?
podspecfile.Releasing a new major version?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.