feat: add secondary subtitle track support via mpv secondary-sid#146
Open
lakshayrastogi wants to merge 1 commit into
Open
feat: add secondary subtitle track support via mpv secondary-sid#146lakshayrastogi wants to merge 1 commit into
lakshayrastogi wants to merge 1 commit into
Conversation
…ary-sid Adds selectedSecondarySubtitlesTrackId prop mapped to mpv's native secondary-sid property, enabling simultaneous rendering of two subtitle tracks for language learning workflows. - Map selectedSecondarySubtitlesTrackId -> mpv secondary-sid - Observe secondary-sid property changes from mpv - Handle setProp for selectedSecondarySubtitlesTrackId - Reset secondary-sid state on unload - Emit secondarySubtitlesTrackLoaded event
lakshayrastogi
force-pushed
the
feature/secondary-subtitle
branch
from
b068382 to
aa4f870
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
selectedSecondarySubtitlesTrackIdprop to ShellVideo, mapping it to mpv's nativesecondary-sidproperty. This enables rendering a second subtitle track simultaneously with the primary one for language learning workflows.Changes (
src/ShellVideo/ShellVideo.js)selectedSecondarySubtitlesTrackId: 'secondary-sid'tostremioToMPVPropsmappingmpv-observe-propforsecondary-sidsecondary-sidcase in the mpv property change event handlerselectedSecondarySubtitlesTrackIdcase insetProp()secondary-sidto null onunloadsecondarySubtitlesTrackLoadedevent to manifestRelated
Related PRs