Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (65)
✅ Files skipped from review due to trivial changes (21)
🚧 Files skipped from review as they are similar to previous changes (39)
WalkthroughThe package version in apps/comments-ui was bumped from 1.4.2 to 1.4.3 and a new runtime dependency, 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27174 +/- ##
==========================================
- Coverage 73.13% 73.12% -0.01%
==========================================
Files 1531 1531
Lines 121987 121987
Branches 14701 14699 -2
==========================================
- Hits 89218 89206 -12
+ Misses 31774 31764 -10
- Partials 995 1017 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ghost/i18n/locales/it/comments.json`:
- Line 77: The Italian locale file is missing a translation for the key "You
can't post comments in this publication. <a>Contact support</a> for more
information." in comments.json which will cause a fallback to English; add an
appropriate Italian translation string for that exact key in the
it/comments.json file (preserving the HTML <a> tag) so the UI uses the Italian
text (update the value for the key rather than adding a new key).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 390141fa-dfb7-4127-bea2-60d3f341b8ad
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (65)
apps/comments-ui/package.jsonapps/comments-ui/src/components/content/commenting-disabled-box.tsxghost/i18n/locales/af/comments.jsonghost/i18n/locales/ar/comments.jsonghost/i18n/locales/bg/comments.jsonghost/i18n/locales/bn/comments.jsonghost/i18n/locales/bs/comments.jsonghost/i18n/locales/ca/comments.jsonghost/i18n/locales/context.jsonghost/i18n/locales/cs/comments.jsonghost/i18n/locales/da/comments.jsonghost/i18n/locales/de-CH/comments.jsonghost/i18n/locales/de/comments.jsonghost/i18n/locales/el/comments.jsonghost/i18n/locales/en/comments.jsonghost/i18n/locales/eo/comments.jsonghost/i18n/locales/es/comments.jsonghost/i18n/locales/et/comments.jsonghost/i18n/locales/eu/comments.jsonghost/i18n/locales/fa/comments.jsonghost/i18n/locales/fi/comments.jsonghost/i18n/locales/fr/comments.jsonghost/i18n/locales/gd/comments.jsonghost/i18n/locales/he/comments.jsonghost/i18n/locales/hi/comments.jsonghost/i18n/locales/hr/comments.jsonghost/i18n/locales/hu/comments.jsonghost/i18n/locales/id/comments.jsonghost/i18n/locales/is/comments.jsonghost/i18n/locales/it/comments.jsonghost/i18n/locales/ja/comments.jsonghost/i18n/locales/ko/comments.jsonghost/i18n/locales/kz/comments.jsonghost/i18n/locales/lt/comments.jsonghost/i18n/locales/lv/comments.jsonghost/i18n/locales/mk/comments.jsonghost/i18n/locales/mn/comments.jsonghost/i18n/locales/ms/comments.jsonghost/i18n/locales/nb/comments.jsonghost/i18n/locales/ne/comments.jsonghost/i18n/locales/nl/comments.jsonghost/i18n/locales/nn/comments.jsonghost/i18n/locales/pa/comments.jsonghost/i18n/locales/pl/comments.jsonghost/i18n/locales/pt-BR/comments.jsonghost/i18n/locales/pt/comments.jsonghost/i18n/locales/ro/comments.jsonghost/i18n/locales/ru/comments.jsonghost/i18n/locales/si/comments.jsonghost/i18n/locales/sk/comments.jsonghost/i18n/locales/sl/comments.jsonghost/i18n/locales/sq/comments.jsonghost/i18n/locales/sr-Cyrl/comments.jsonghost/i18n/locales/sr/comments.jsonghost/i18n/locales/sv/comments.jsonghost/i18n/locales/sw/comments.jsonghost/i18n/locales/ta/comments.jsonghost/i18n/locales/th/comments.jsonghost/i18n/locales/tr/comments.jsonghost/i18n/locales/uk/comments.jsonghost/i18n/locales/ur/comments.jsonghost/i18n/locales/uz/comments.jsonghost/i18n/locales/vi/comments.jsonghost/i18n/locales/zh-Hant/comments.jsonghost/i18n/locales/zh/comments.json
cathysarisky
requested changes
Apr 6, 2026
Member
cathysarisky
left a comment
cathysarisky
left a comment
There was a problem hiding this comment.
This is a huge improvement in translate-ability, thank you!
To avoid losing existing translations, I reconstructed a couple spots where we already had strings. That way we keep whatever translators had already settled on (still available for improvements, or course!) instead of having those revert to English.
ghost/i18n/locales/bg/comments.json
Outdated
| "View in admin": "Преглед в админ панела", | ||
| "Yesterday": "Вчера", | ||
| "You can't post comments in this publication.": "Не може да коментирате под тази публикация.", | ||
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "", |
Member
There was a problem hiding this comment.
Suggested change
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "", | |
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "Не може да коментирате под тази публикация. <a>Връзка с поддръжката</a> за повече информация.", |
| "View in admin": "Im Admin anzeigen", | ||
| "Yesterday": "Gestern", | ||
| "You can't post comments in this publication.": "Sie können in dieser Publikation keine Kommentare schreiben.", | ||
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "", |
Member
There was a problem hiding this comment.
Suggested change
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "", | |
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "Sie können in dieser Publikation keine Kommentare schreiben. <a>Kontaktieren Sie den Support</a> für weitere Informationen.", |
ghost/i18n/locales/it/comments.json
Outdated
| "View in admin": "Visualizza nell'area admin", | ||
| "Yesterday": "Ieri", | ||
| "You can't post comments in this publication.": "Non puoi postare commenti in questa pubblicazione.", | ||
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "", |
Member
There was a problem hiding this comment.
Suggested change
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "", | |
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "Non puoi postare commenti in questa pubblicazione. <a>Contatta il supporto</a> per maggiori informazioni.", |
| "View in admin": "Погледајте у админ", | ||
| "Yesterday": "Јуче", | ||
| "You can't post comments in this publication.": "Не можете објављивати коментаре у овој публикацији.", | ||
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "", |
Member
There was a problem hiding this comment.
Suggested change
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "", | |
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "Не можете објављивати коментаре у овој публикацији. <a>Контактирајте подршку</a> за више информација.", |
ghost/i18n/locales/sr/comments.json
Outdated
| "View in admin": "Pogledajte u admin", | ||
| "Yesterday": "Juče", | ||
| "You can't post comments in this publication.": "Ne možete objavljivati komentare u ovoj publikaciji.", | ||
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "", |
Member
There was a problem hiding this comment.
Suggested change
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "", | |
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "Ne možete objavljivati komentare u ovoj publikaciji. <a>Kontaktirajte podršku</a> za više informacija.", |
| "View in admin": "從管理後台檢視", | ||
| "Yesterday": "昨天", | ||
| "You can't post comments in this publication.": "您無法在此刊物留言。", | ||
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "", |
Member
There was a problem hiding this comment.
Suggested change
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "", | |
| "You can't post comments in this publication. <a>Contact support</a> for more information.": "您無法在此刊物留言。<a>聯繫客服</a> 以取得更多資訊。", |
…polated string
Replaced three separate translation keys ("You can't post comments...", "Contact support",
"for more information.") with a single key using <a> tag interpolation via
@doist/react-interpolate. Fragmented keys made it impossible for translators to
produce grammatically correct sentences in languages with different word order.
Applied @cathysarisky's translations for bg, de-CH, it, sr-Cyrl, sr, zh-Hant for the new combined commenting-disabled key. Bumped version to 1.4.3 since main already has 1.4.2.
rob-ghost
force-pushed
the
fix/commenting-disabled-translation-keys
branch
from
f04ac6a to
a1f2cab
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commenting-disabled box in comments-ui previously rendered its message using three separate translation keys: "You can't post comments in this publication.", "Contact support", and "for more information." This fragmented approach made it difficult for translators to produce natural-sounding sentences, since word order and grammar vary across languages. Splitting a sentence into independent fragments forces translators to work around English syntax rather than expressing the idea naturally in their own language.
This change consolidates those three keys into a single interpolated string:
"You can't post comments in this publication. <a>Contact support</a> for more information."The<a>tag is handled at render time by@doist/react-interpolate, which swaps it for the actual mailto link element. Translators now see the full sentence and can reorder or restructure it freely while keeping the link in the right place.All 63 locale files have been updated to remove the two obsolete keys and add the new combined key (with an empty value, ready for translation). The context file has also been updated with descriptions for the new key and a couple of previously undocumented keys.