🌐 Backfilled empty i18n context.json strings#27170
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis pull request updates 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cathysarisky
left a comment
There was a problem hiding this comment.
Thanks so much for adding these, @troyciesco ! Just one tiny fix (because translators don't have an easy way to see what gets substituted where)
ff89f55 to
fca6716
Compare
cathysarisky
left a comment
There was a problem hiding this comment.
LGTM! Thanks for improving! (Note, depending on merge order: there's another PR that fixes "for more information" so a little attention to merge may be needed)
Oh thanks for flagging! it looks like @rob-ghost and I had the same idea (both probably based on your good suggestion, @cathysarisky - at least mine was) for improvement within a couple hours of each other lol. Rob I see you have a few related PRs in flight and some already have conflicts/need more work etc, ill figure out what order to merge stuff in to make things easier for you tomorrow. I think merging this and my generate-context PR (#27171) will mean you can close #27176 that also does those two things, and you'll have less overall conflicts in #27175 and #27174 |
fca6716 to
f744416
Compare
f744416 to
fee347a
Compare
|
no ref - We have CI checks to make sure that new i18n keys are added to context.json when they're generated, but there's no requirement to add any actual explanation for the key - This fixes that. When generate-context.js runs locally it will log a warning, but in CI it will error - This will apply to any i18n strings added from here on out - existing empty strings will be backfilled in #27170



no ref
context.json