Skip to content

🌐 Backfilled empty i18n context.json strings#27170

Merged
troyciesco merged 1 commit intomainfrom
i18n-context-ci-context-vals
Apr 7, 2026
Merged

🌐 Backfilled empty i18n context.json strings#27170
troyciesco merged 1 commit intomainfrom
i18n-context-ci-context-vals

Conversation

@troyciesco
Copy link
Copy Markdown
Contributor

@troyciesco troyciesco commented Apr 6, 2026

no ref

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: acecaf2d-bdc7-4b22-ae47-5c5808209880

📥 Commits

Reviewing files that changed from the base of the PR and between f744416 and fee347a.

📒 Files selected for processing (1)
  • ghost/i18n/locales/context.json

Walkthrough

This pull request updates ghost/i18n/locales/context.json, replacing previously empty context strings with descriptive, Portal- and flow-specific context for existing translation keys. Updated contexts cover subscription cancellation retention offers (single/multi-month free and discount variants), Portal headings and controls for retention/cancellation, one-time-code sign-in UI and email text, Stripe billing-portal failure messages, donations-disabled messaging, and a fallback for a missing inbox label. No keys were added or removed; the file still lacks a trailing newline.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly indicates the main change: backfilling empty i18n context.json strings with descriptive text.
Description check ✅ Passed The description is directly related to the changeset, explaining the backfill of empty i18n context hints and referencing a follow-up PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch i18n-context-ci-context-vals

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@cathysarisky cathysarisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for adding these, @troyciesco ! Just one tiny fix (because translators don't have an easy way to see what gets substituted where)

@troyciesco troyciesco force-pushed the i18n-context-ci-context-vals branch 2 times, most recently from ff89f55 to fca6716 Compare April 6, 2026 18:04
@troyciesco troyciesco requested a review from cathysarisky April 6, 2026 19:05
Copy link
Copy Markdown
Member

@cathysarisky cathysarisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for improving! (Note, depending on merge order: there's another PR that fixes "for more information" so a little attention to merge may be needed)

@troyciesco
Copy link
Copy Markdown
Contributor Author

LGTM! Thanks for improving! (Note, depending on merge order: there's another PR that fixes "for more information" so a little attention to merge may be needed)

Oh thanks for flagging! it looks like @rob-ghost and I had the same idea (both probably based on your good suggestion, @cathysarisky - at least mine was) for improvement within a couple hours of each other lol.

Rob I see you have a few related PRs in flight and some already have conflicts/need more work etc, ill figure out what order to merge stuff in to make things easier for you tomorrow.

I think merging this and my generate-context PR (#27171) will mean you can close #27176 that also does those two things, and you'll have less overall conflicts in #27175 and #27174

@troyciesco troyciesco changed the title Backfilled empty i18n context.json strings 🌐 Backfilled empty i18n context.json strings Apr 6, 2026
@troyciesco troyciesco requested a review from rob-ghost April 7, 2026 01:01
@troyciesco troyciesco force-pushed the i18n-context-ci-context-vals branch from fca6716 to f744416 Compare April 7, 2026 12:38
@troyciesco troyciesco force-pushed the i18n-context-ci-context-vals branch from f744416 to fee347a Compare April 7, 2026 13:53
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 7, 2026

@troyciesco troyciesco merged commit f38b23e into main Apr 7, 2026
39 checks passed
@troyciesco troyciesco deleted the i18n-context-ci-context-vals branch April 7, 2026 14:33
troyciesco added a commit that referenced this pull request Apr 7, 2026
no ref

- We have CI checks to make sure that new i18n keys are added to
context.json when they're generated, but there's no requirement to add
any actual explanation for the key
- This fixes that. When generate-context.js runs locally it will log a
warning, but in CI it will error
- This will apply to any i18n strings added from here on out - existing
empty strings will be backfilled in
#27170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants