Skip to content

feat: added wsEmbedDappClientId to auth#400

Merged
chaitanyapotti merged 3 commits intomasterfrom
feat/embed-client-id
Apr 28, 2026
Merged

feat: added wsEmbedDappClientId to auth#400
chaitanyapotti merged 3 commits intomasterfrom
feat/embed-client-id

Conversation

@lwin-kyaw
Copy link
Copy Markdown
Contributor

@lwin-kyaw lwin-kyaw commented Apr 27, 2026

Jira Link

Description

This PR accepts wsEmbedDappClientId in Auth's constructor args and the auth instance will pass it to the auth-service for both default and iframe mode.

How has this been tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note

Low Risk
Low risk because changes are limited to a new optional AuthOptions field and package-lock.json metadata updates, with no runtime logic changes shown in the diff.

Overview
Adds a new optional AuthOptions.wsEmbedDappClientId parameter (documented for EMBED mode) to allow callers to supply the initiating dapp’s client id.

Also updates package-lock.json to mark several dev dependencies as peer (lockfile metadata-only changes).

Reviewed by Cursor Bugbot for commit 8b5beab. Bugbot is set up for automated code reviews on this repo. Configure here.

@lwin-kyaw lwin-kyaw requested review from a team as code owners April 27, 2026 17:47
Comment thread src/core/auth.ts Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a389621. Configure here.

Comment thread src/utils/interfaces.ts Outdated
* The client id of the dapp that initiates the login flow in **EMBED** mode.
* @defaultValue undefined
*/
wsEmbedDappClientId?: string;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wsEmbedDappClientId added to BaseLoginParams but never populated

High Severity

The wsEmbedDappClientId field is added to both AuthOptions and BaseLoginParams, but the code in auth.ts that constructs BaseLoginParams objects (in authHandler and manageMFA) is never updated to include wsEmbedDappClientId: this.options.wsEmbedDappClientId. This means the value accepted via AuthOptions will never be forwarded to the auth-service through the URL config params, making the feature non-functional for the default flow.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a389621. Configure here.

@chaitanyapotti chaitanyapotti merged commit 556b3d2 into master Apr 28, 2026
5 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/embed-client-id branch April 28, 2026 04:03
@chaitanyapotti chaitanyapotti changed the title feat: added wsEmabedDappClientId to auth feat: added wsEmbedDappClientId to auth Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants