feat: added wsEmbedDappClientId to auth#400
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a389621. Configure here.
| * The client id of the dapp that initiates the login flow in **EMBED** mode. | ||
| * @defaultValue undefined | ||
| */ | ||
| wsEmbedDappClientId?: string; |
There was a problem hiding this comment.
wsEmbedDappClientId added to BaseLoginParams but never populated
High Severity
The wsEmbedDappClientId field is added to both AuthOptions and BaseLoginParams, but the code in auth.ts that constructs BaseLoginParams objects (in authHandler and manageMFA) is never updated to include wsEmbedDappClientId: this.options.wsEmbedDappClientId. This means the value accepted via AuthOptions will never be forwarded to the auth-service through the URL config params, making the feature non-functional for the default flow.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit a389621. Configure here.


Jira Link
Description
This PR accepts
wsEmbedDappClientIdin Auth's constructor args and the auth instance will pass it to the auth-service for bothdefaultandiframemode.How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Note
Low Risk
Low risk because changes are limited to a new optional
AuthOptionsfield andpackage-lock.jsonmetadata updates, with no runtime logic changes shown in the diff.Overview
Adds a new optional
AuthOptions.wsEmbedDappClientIdparameter (documented for EMBED mode) to allow callers to supply the initiating dapp’s client id.Also updates
package-lock.jsonto mark several dev dependencies aspeer(lockfile metadata-only changes).Reviewed by Cursor Bugbot for commit 8b5beab. Bugbot is set up for automated code reviews on this repo. Configure here.