Skip to content

feat: added wsEmbedDappClientId to auth #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaitanyapotti merged 3 commits into from
Apr 28, 2026
Merged

feat: added wsEmbedDappClientId to auth #400

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7c955a
feat: added wsEmabedDappClientId to auth
lwin-kyaw Apr 27, 2026
a389621
fix: removed 'wsEmbedDappClientID' from login base params
lwin-kyaw Apr 27, 2026
8b5beab
chore: revert BaseLoginParams interface
lwin-kyaw Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions src/utils/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,12 @@ export type AuthOptions = {
* @defaultValue true
*/
includeUserDataInToken?: boolean;

/**
* The client id of the dapp that initiates the login flow in **EMBED** mode.
* @defaultValue undefined
*/
wsEmbedDappClientId?: string;
};

export interface BaseLoginParams {
Expand All @@ -564,6 +570,12 @@ export interface BaseLoginParams {
* Optional login source to be used for analytics purposes.
*/
loginSource?: string;

/**
* The client id of the dapp that initiates the login flow in **EMBED** mode.
* @defaultValue undefined
*/
wsEmbedDappClientId?: string;
Copy link
Copy Markdown

@cursor cursor Bot Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wsEmbedDappClientId added to BaseLoginParams but never populated

High Severity

The wsEmbedDappClientId field is added to both AuthOptions and BaseLoginParams, but the code in auth.ts that constructs BaseLoginParams objects (in authHandler and manageMFA) is never updated to include wsEmbedDappClientId: this.options.wsEmbedDappClientId. This means the value accepted via AuthOptions will never be forwarded to the auth-service through the URL config params, making the feature non-functional for the default flow.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a389621. Configure here.

}

export interface AuthRequestPayload {
Expand Down
Loading