fix: guard against zero/excess column count in ExecuteBulkIngest#109
Open
eitsupi wants to merge 1 commit into
Open
fix: guard against zero/excess column count in ExecuteBulkIngest#109eitsupi wants to merge 1 commit into
eitsupi wants to merge 1 commit into
Conversation
When a schema with zero columns was passed to ExecuteBulkIngest, the expression `MySQLMaxPlaceholders / numCols` caused a division-by-zero panic. Schemas with more than 65,535 columns would silently produce a batch size of zero. Add explicit early-return errors for both cases, consistent with how the Dolt driver handles the same condition. Move validation ahead of the `createTableIfNeeded` call so no database interaction occurs for invalid inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
When a schema with zero columns was passed to ExecuteBulkIngest, the expression
MySQLMaxPlaceholders / numColscaused a division-by-zero panic. Schemas with more than 65,535 columns would silently produce a batch size of zero.Add explicit early-return errors for both cases, consistent with how the Dolt driver handles the same condition. Move validation ahead of the
createTableIfNeededcall so no database interaction occurs for invalid inputs.