Skip to content

fix: guard against zero/excess column count in ExecuteBulkIngest #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 1 commit into from
Jun 14, 2026
+17 −5
Merged

fix: guard against zero/excess column count in ExecuteBulkIngest #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions go/connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,11 +242,8 @@ var _ sqlwrapper.BulkIngester = (*mysqlConnectionImpl)(nil)
// ExecuteBulkIngest performs MySQL bulk ingest using batched INSERT statements.
func (c *mysqlConnectionImpl) ExecuteBulkIngest(ctx context.Context, conn *sqlwrapper.LoggingConn, options *driverbase.BulkIngestOptions, stream array.RecordReader) (rowCount int64, err error) {
schema := stream.Schema()
if err := c.createTableIfNeeded(ctx, conn, options.TableName, schema, options); err != nil {
return -1, c.ErrorHelper.WrapIO(err, "failed to create table")
}

// Validate MySQL-specific options
// Validate MySQL-specific options before touching the database.
if options.MaxQuerySizeBytes > 0 {
return -1, c.ErrorHelper.InvalidArgument(
"MySQL driver does not support '%s'. "+
Expand All @@ -255,9 +252,24 @@ func (c *mysqlConnectionImpl) ExecuteBulkIngest(ctx context.Context, conn *sqlwr
driverbase.OptionKeyIngestBatchSize)
}

// Guard against division by zero and schemas that exceed MySQL's 65,535
// placeholder limit before any database interaction.
numCols := len(schema.Fields())
if numCols == 0 {
return -1, c.ErrorHelper.InvalidArgument("bulk ingest schema must have at least one column")
}
if numCols > MySQLMaxPlaceholders {
return -1, c.ErrorHelper.InvalidArgument(
"bulk ingest schema has %d columns, exceeding the MySQL placeholder limit of %d",
numCols, MySQLMaxPlaceholders)
}

if err := c.createTableIfNeeded(ctx, conn, options.TableName, schema, options); err != nil {
return -1, c.ErrorHelper.WrapIO(err, "failed to create table")
}

// Set MySQL-specific default batch size if user hasn't overridden,
// capping to stay within MySQL's 65,535 placeholder limit.
numCols := len(schema.Fields())
maxBatchSize := MySQLMaxPlaceholders / numCols
if options.IngestBatchSize == 0 {
options.IngestBatchSize = min(MySQLDefaultIngestBatchSize, maxBatchSize)
Expand Down
Loading